github
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | pull_request | body | repo | type | active_lock_reason | performed_via_github_app | reactions | draft | state_reason |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
725099777 | MDU6SXNzdWU3MjUwOTk3Nzc= | 1033 | datasette.urls.static_plugins(...) method | 9599 | closed | 0 | 6026070 | 5 | 2020-10-20T01:16:32Z | 2020-10-24T22:58:33Z | 2020-10-24T20:03:52Z | OWNER | Follow-on from #904. For constructing URLs like this: /-/static-plugins/NAME_OF_PLUGIN_PACKAGE/yourfile.js Should be documented on https://docs.datasette.io/en/latest/writing_plugins.html#static-assets and https://docs.datasette.io/en/latest/internals.html#datasette-urls | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/1033/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
497162288 | MDU6SXNzdWU0OTcxNjIyODg= | 575 | Plugin documentation should cover how to bundle static/templates in setup.py | 9599 | closed | 0 | 6026070 | 1 | 2019-09-23T15:15:18Z | 2020-10-24T20:06:17Z | 2020-10-24T20:03:53Z | OWNER | These sections here should cover it: https://datasette.readthedocs.io/en/latest/plugins.html#static-assets Example: https://github.com/simonw/datasette-auth-github/blob/bf01f8f01b87a6cb09c47380ba0a86e0546ebb38/setup.py#L30 ``` package_data={"datasette_auth_github": ["templates/*.html"]}, ``` Also from https://github.com/simonw/datasette-plugin-demos/blob/0ccf9e6189e923046047acd7878d1d19a2cccbb1/setup.py#L18-L22 package_data={ 'datasette_plugin_demos': [ 'static/plugin.js', ], }, | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/575/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
728600048 | MDU6SXNzdWU3Mjg2MDAwNDg= | 1045 | Document that datasette.render_template(template, ...) also accepts a list of templates | 9599 | closed | 0 | 6026070 | 1 | 2020-10-23T23:37:12Z | 2020-10-24T00:22:10Z | 2020-10-24T00:22:09Z | OWNER | https://docs.datasette.io/en/stable/internals.html#await-render-template-template-context-none-request-none `await .render_template(template, context=None, request=None)` This currently only accepts a single template. If it accepted a list of templates (where the first available template gets rendered) it could be more widely used by Datasette internally. Spotted this while researching #1042. | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/1045/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed |