github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/744#issuecomment-635384739 | https://api.github.com/repos/simonw/datasette/issues/744 | 635384739 | MDEyOklzc3VlQ29tbWVudDYzNTM4NDczOQ== | 9599 | 2020-05-28T14:28:58Z | 2020-05-28T14:28:58Z | OWNER | This is now released. `pip install datasette==0.43` should get the fix. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-634850676 | https://api.github.com/repos/simonw/datasette/issues/744 | 634850676 | MDEyOklzc3VlQ29tbWVudDYzNDg1MDY3Ng== | 9599 | 2020-05-27T18:18:01Z | 2020-05-27T18:18:01Z | OWNER | Thanks for helping test this @aborruso! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-634395343 | https://api.github.com/repos/simonw/datasette/issues/744 | 634395343 | MDEyOklzc3VlQ29tbWVudDYzNDM5NTM0Mw== | 9599 | 2020-05-27T02:49:26Z | 2020-05-27T02:49:26Z | OWNER | OK, here's a new branch you can try. Install it like this: pip install https://github.com/simonw/datasette/archive/shutil-backport.zip If it works for you I'll merge that branch into master. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-634254943 | https://api.github.com/repos/simonw/datasette/issues/744 | 634254943 | MDEyOklzc3VlQ29tbWVudDYzNDI1NDk0Mw== | 9599 | 2020-05-26T20:15:11Z | 2020-05-26T20:15:11Z | OWNER | Oh no! It looks like `dirs_exist_ok` is Python 3.8 only. This is a bad fix, it needs to work on older Python's too. Re-opening. | { "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-634254700 | https://api.github.com/repos/simonw/datasette/issues/744 | 634254700 | MDEyOklzc3VlQ29tbWVudDYzNDI1NDcwMA== | 9599 | 2020-05-26T20:14:35Z | 2020-05-26T20:14:35Z | OWNER | What version of Python are you running? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-632253073 | https://api.github.com/repos/simonw/datasette/issues/744 | 632253073 | MDEyOklzc3VlQ29tbWVudDYzMjI1MzA3Mw== | 9599 | 2020-05-21T17:54:55Z | 2020-05-21T17:54:55Z | OWNER | I think this is the fix! I just landed it in master. @aborruso you can install Datasette master to test it out like this: pip install https://github.com/simonw/datasette/archive/cee671a58f417f827d1735b1abaa40716534ea67.zip | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-632237195 | https://api.github.com/repos/simonw/datasette/issues/744 | 632237195 | MDEyOklzc3VlQ29tbWVudDYzMjIzNzE5NQ== | 9599 | 2020-05-21T17:23:39Z | 2020-05-21T17:23:48Z | OWNER | Actually maybe the answer here is to use `dirs_exist_ok=True` when calling `shutil.copytree`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-632233393 | https://api.github.com/repos/simonw/datasette/issues/744 | 632233393 | MDEyOklzc3VlQ29tbWVudDYzMjIzMzM5Mw== | 9599 | 2020-05-21T17:16:15Z | 2020-05-21T17:17:43Z | OWNER | I just hit this bug myself, or at least a variant of it! https://github.com/simonw/museums/runs/697063068?check_suite_focus=true ``` 2020-05-21T17:14:02.2596471Z Traceback (most recent call last): 2020-05-21T17:14:02.2599146Z File "/opt/hostedtoolcache/Python/3.8.3/x64/lib/python3.8/site-packages/datasette/utils/__init__.py", line 605, in link_or_copy_directory 2020-05-21T17:14:02.2599861Z shutil.copytree(src, dst, copy_function=os.link) 2020-05-21T17:14:02.2600377Z File "/opt/hostedtoolcache/Python/3.8.3/x64/lib/python3.8/shutil.py", line 554, in copytree 2020-05-21T17:14:02.2600786Z return _copytree(entries=entries, src=src, dst=dst, symlinks=symlinks, 2020-05-21T17:14:02.2601196Z File "/opt/hostedtoolcache/Python/3.8.3/x64/lib/python3.8/shutil.py", line 510, in _copytree 2020-05-21T17:14:02.2601580Z raise Error(errors) 2020-05-21T17:14:02.2604565Z shutil.Error: [('/home/runner/work/museums/museums/templates/row-browse-museums.html', '/tmp/tmpq47xi96y/datasette/templates/row-browse-museums.html', "[Errno 18] Invalid cross-device link: '/home/runner/work/museums/museums/templates/row-browse-museums.html' -> '/tmp/tmpq47xi96y/datasette/templates/row-browse-museums.html'"), ('/home/runner/work/museums/museums/templates/index.html', '/tmp/tmpq47xi96y/datasette/templates/index.html', "[Errno 18] Invalid cross-device link: '/home/runner/work/museums/museums/templates/index.html' -> '/tmp/tmpq47xi96y/datasette/templates/index.html'"), ('/home/runner/work/museums/museums/templates/query-browse-search.html', '/tmp/tmpq47xi96y/datasette/templates/query-browse-search.html', "[Errno 18] Invalid cross-device link: '/home/runner/work/museums/museums/templates/query-browse-search.html' -> '/tmp/tmpq47xi96y/datasette/templates/query-browse-search.html'"), ('/home/runner/work/museums/museums/templates/_analytics.html', '/tmp/tmpq47xi96y/datasette/templates/_analytics.html', "[Errno 18] Invalid cross-device link: '/home/runner/work/museums/museums/templates/_analytics.html' -> '/tmp/tmpq47xi96y… | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-625066876 | https://api.github.com/repos/simonw/datasette/issues/744 | 625066876 | MDEyOklzc3VlQ29tbWVudDYyNTA2Njg3Ng== | 9599 | 2020-05-07T06:55:04Z | 2020-05-07T06:55:04Z | OWNER | I have a Windows 10 gaming PC in the house: what steps can I take to get an environment in there that matches yours? I've not installed Python on Windows before. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-625061250 | https://api.github.com/repos/simonw/datasette/issues/744 | 625061250 | MDEyOklzc3VlQ29tbWVudDYyNTA2MTI1MA== | 9599 | 2020-05-07T06:40:09Z | 2020-05-07T06:40:09Z | OWNER | Have a try and let me know what happens! I'd like this stuff to just work on Windows but I need to figure out how to get an environment working. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-621027697 | https://api.github.com/repos/simonw/datasette/issues/744 | 621027697 | MDEyOklzc3VlQ29tbWVudDYyMTAyNzY5Nw== | 9599 | 2020-04-29T07:08:09Z | 2020-04-29T07:08:09Z | OWNER | What operating system are you using? I need to figure out a way to replicate this bug. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-620971526 | https://api.github.com/repos/simonw/datasette/issues/744 | 620971526 | MDEyOklzc3VlQ29tbWVudDYyMDk3MTUyNg== | 9599 | 2020-04-29T03:32:14Z | 2020-04-29T03:32:14Z | OWNER | @aborruso I think I have a branch with a fix - could you try it out? Install the new branch like this: ``` pip install https://github.com/simonw/datasette/archive/issue-744.zip ``` Then try running `datasette publish heroku` again. If this fixes your bug I'll merge that pull request! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-620970475 | https://api.github.com/repos/simonw/datasette/issues/744 | 620970475 | MDEyOklzc3VlQ29tbWVudDYyMDk3MDQ3NQ== | 9599 | 2020-04-29T03:27:20Z | 2020-04-29T03:27:20Z | OWNER | This exception handling was introduced in #141 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-620970159 | https://api.github.com/repos/simonw/datasette/issues/744 | 620970159 | MDEyOklzc3VlQ29tbWVudDYyMDk3MDE1OQ== | 9599 | 2020-04-29T03:25:45Z | 2020-04-29T03:25:45Z | OWNER | https://docs.python.org/3/library/shutil.html#shutil.copytree says that `shutil.Error` should be raised here, so I think this is a bug in the `link_or_copy_directory` function. I don't have an environment that can replicate this bug. @aborruso I'm going to ship a fix in a branch that you can test against. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-620969639 | https://api.github.com/repos/simonw/datasette/issues/744 | 620969639 | MDEyOklzc3VlQ29tbWVudDYyMDk2OTYzOQ== | 9599 | 2020-04-29T03:23:31Z | 2020-04-29T03:23:31Z | OWNER | Is it possible that your `/tmp` directory is on a different volume from the `template` folder? That could cause a problem with the symlinks. Here's the code in question: https://github.com/simonw/datasette/blob/89c4ddd4828623888e91a1d2cb396cba12d4e7b4/datasette/utils/__init__.py#L595-L609 It looks to me like we were expecting an `OSError` but in your environment you got a `shutil.Error` instead. So a fix could be to capture that error as well. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 |