github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/770#issuecomment-634880090 | https://api.github.com/repos/simonw/datasette/issues/770 | 634880090 | MDEyOklzc3VlQ29tbWVudDYzNDg4MDA5MA== | 9599 | 2020-05-27T19:10:57Z | 2020-05-28T04:22:47Z | OWNER | This `can_render` callback should take the same arguments as the redesigned `render` (previously called `callback`): https://github.com/simonw/datasette/issues/581#issuecomment-634879258 - `datasette` - a Datasette instance - `columns` - the list of columns - `rows` - the list of rows (each one a SQLite `Row` object) - `sql` - the SQL query being executed - `query_name` - the name of the canned query, if this is one - `database` - the database name - `table` - the table or view name - `request` - the request object (to be documented in #706) - `view_name` - the name of the view | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
625930207 | |
https://github.com/simonw/datasette/issues/770#issuecomment-635056520 | https://api.github.com/repos/simonw/datasette/issues/770 | 635056520 | MDEyOklzc3VlQ29tbWVudDYzNTA1NjUyMA== | 9599 | 2020-05-28T02:28:00Z | 2020-05-28T02:28:00Z | OWNER | This should be optionally awaitable, as in #776 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
625930207 | |
https://github.com/simonw/datasette/issues/770#issuecomment-634980179 | https://api.github.com/repos/simonw/datasette/issues/770 | 634980179 | MDEyOklzc3VlQ29tbWVudDYzNDk4MDE3OQ== | 9599 | 2020-05-27T22:37:19Z | 2020-05-27T22:37:19Z | OWNER | Can I come up with a better name than `should_suggest`? It's a check that sees if the current query is supported by the renderer plugin. Some options: - `can_render` - `supports_query` - `is_supported` I like `can_render`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
625930207 | |
https://github.com/simonw/datasette/issues/770#issuecomment-634880474 | https://api.github.com/repos/simonw/datasette/issues/770 | 634880474 | MDEyOklzc3VlQ29tbWVudDYzNDg4MDQ3NA== | 9599 | 2020-05-27T19:11:39Z | 2020-05-27T19:11:39Z | OWNER | I'm going to rename `callback` to `render` but continue supporting `callback` until Datasette 1.0. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
625930207 |