github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/777#issuecomment-640957423 | https://api.github.com/repos/simonw/datasette/issues/777 | 640957423 | MDEyOklzc3VlQ29tbWVudDY0MDk1NzQyMw== | 9599 | 2020-06-09T00:29:03Z | 2020-06-09T00:29:03Z | OWNER | Here's why: https://github.com/simonw/datasette/blob/49d6d2f7b0f6cb02e25022e1c9403811f1fa0a7c/datasette/app.py#L1024-L1029 404 errors are rendered by looking for a template from `["404.html", "500.html"]`. `404.html` doesn't actually ship with Datasette (plugins or custom template directories can provide it). So the `500.html` template is used. That template extends `base.html`, which expects there to be `base_url` and `app_css_hash` variables. But as you can see in the excerpt above, those variables are not being passed to the template context when the error page is rendered. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626171242 | |
https://github.com/simonw/datasette/issues/777#issuecomment-640955788 | https://api.github.com/repos/simonw/datasette/issues/777 | 640955788 | MDEyOklzc3VlQ29tbWVudDY0MDk1NTc4OA== | 9599 | 2020-06-09T00:23:26Z | 2020-06-09T00:23:57Z | OWNER | Clue: https://latest.datasette.io/404 displays correctly but https://latest.datasette.io/fixtures/404 does not. That's because `<link rel="stylesheet" href="-/static/app.css?">` does the correct thing if you are on the root of the site but not if you are in a sub-directory. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626171242 | |
https://github.com/simonw/datasette/issues/777#issuecomment-640925018 | https://api.github.com/repos/simonw/datasette/issues/777 | 640925018 | MDEyOklzc3VlQ29tbWVudDY0MDkyNTAxOA== | 9599 | 2020-06-08T22:41:42Z | 2020-06-08T22:41:42Z | OWNER | This is particularly worth fixing now that 403 forbidden pages are much more likely due to #811. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626171242 | |
https://github.com/simonw/datasette/issues/777#issuecomment-635513983 | https://api.github.com/repos/simonw/datasette/issues/777 | 635513983 | MDEyOklzc3VlQ29tbWVudDYzNTUxMzk4Mw== | 63653929 | 2020-05-28T18:16:49Z | 2020-05-28T18:16:49Z | NONE | think, because the given URL of the CSS file doesn't have any complete parameters after query Try to complete the parameter `<link rel="stylesheet" href="-/static/app.css?(whatever you want that shows a css file)">` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626171242 |