github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/812#issuecomment-641353729 | https://api.github.com/repos/simonw/datasette/issues/812 | 641353729 | MDEyOklzc3VlQ29tbWVudDY0MTM1MzcyOQ== | 9599 | 2020-06-09T14:59:25Z | 2020-06-09T14:59:25Z | OWNER | I'm going to figure this out by working with https://github.com/simonw/datasette-auth-github/issues/62 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
634112607 | |
https://github.com/simonw/datasette/issues/812#issuecomment-652163450 | https://api.github.com/repos/simonw/datasette/issues/812 | 652163450 | MDEyOklzc3VlQ29tbWVudDY1MjE2MzQ1MA== | 9599 | 2020-07-01T03:18:51Z | 2020-07-01T03:20:28Z | OWNER | This can be a plugin hook: ```python @hookspec def forbidden(datasette, request, message, send): "Custom response for a 403 forbidden error" ``` If the hook returns a `Response` object, it will be returned to the user. Plugins are likely to want to return a redirect response. Maybe the hook can instead use the `send` argument to respond to the request and return `True` which means "I've responded to this"? I'm going to leave `send` off for the moment - I can add that in the future if it turns out it would have been a good idea. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
634112607 | |
https://github.com/simonw/datasette/issues/812#issuecomment-652165709 | https://api.github.com/repos/simonw/datasette/issues/812 | 652165709 | MDEyOklzc3VlQ29tbWVudDY1MjE2NTcwOQ== | 9599 | 2020-07-01T03:26:35Z | 2020-07-01T03:26:35Z | OWNER | This case may not be covered without extra work: https://github.com/simonw/datasette/blob/3ec5b1abf6afa2d22a3378092809a1a8c0249d26/datasette/views/database.py#L122-L123 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
634112607 |