github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/864#issuecomment-650842514 | https://api.github.com/repos/simonw/datasette/issues/864 | 650842514 | MDEyOklzc3VlQ29tbWVudDY1MDg0MjUxNA== | 9599 | 2020-06-29T00:12:59Z | 2020-06-29T00:12:59Z | OWNER | > I've made enough progress on this to be able to solve the messages issue in #864. I may still complete this overall goal (registering internal views with `register_routes()`) as part of Datasette 0.45 but it would be OK if it slipped to a later release. https://github.com/simonw/datasette/issues/870#issuecomment-650842381 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
644309017 | |
https://github.com/simonw/datasette/issues/864#issuecomment-650846473 | https://api.github.com/repos/simonw/datasette/issues/864 | 650846473 | MDEyOklzc3VlQ29tbWVudDY1MDg0NjQ3Mw== | 9599 | 2020-06-29T00:39:04Z | 2020-06-29T00:39:04Z | OWNER | Re-opening: plugins may get to set messages but they don't display them, even if they render a template that extends `base.html`. For example, this code in a plugin: ```python return Response.html( await datasette.render_template( "write.html", {"databases": databases, "sql": request.args.get("sql") or ""}, request=request, ) ) ``` This won't display messages. The reason is that the messages are made available to the template context in the `BaseView.render()` method here: https://github.com/simonw/datasette/blob/7ac4936cec87f5a591e5d2680f0acefc3d35a705/datasette/views/base.py#L87-L95 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
644309017 | |
https://github.com/simonw/datasette/issues/864#issuecomment-650846625 | https://api.github.com/repos/simonw/datasette/issues/864 | 650846625 | MDEyOklzc3VlQ29tbWVudDY1MDg0NjYyNQ== | 9599 | 2020-06-29T00:39:47Z | 2020-06-29T00:39:47Z | OWNER | I think the fix is to move the `"show_messages"` variable to here: https://github.com/simonw/datasette/blob/7ac4936cec87f5a591e5d2680f0acefc3d35a705/datasette/app.py#L735-L748 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
644309017 | |
https://github.com/simonw/datasette/issues/864#issuecomment-650847013 | https://api.github.com/repos/simonw/datasette/issues/864 | 650847013 | MDEyOklzc3VlQ29tbWVudDY1MDg0NzAxMw== | 9599 | 2020-06-29T00:41:55Z | 2020-06-29T00:41:55Z | OWNER | To test this I'll need a plugin test that renders a custom template. Here's an example I can imitate: https://github.com/simonw/datasette/blob/7ac4936cec87f5a591e5d2680f0acefc3d35a705/tests/test_plugins.py#L588-L596 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
644309017 |