github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/904#issuecomment-709635276 | https://api.github.com/repos/simonw/datasette/issues/904 | 709635276 | MDEyOklzc3VlQ29tbWVudDcwOTYzNTI3Ng== | 9599 | 2020-10-15T23:05:54Z | 2020-10-15T23:05:54Z | OWNER | Could have `instance_url()` take an optional path argument which is then turned into the correct path. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
663228985 | |
https://github.com/simonw/datasette/issues/904#issuecomment-709635021 | https://api.github.com/repos/simonw/datasette/issues/904 | 709635021 | MDEyOklzc3VlQ29tbWVudDcwOTYzNTAyMQ== | 9599 | 2020-10-15T23:05:11Z | 2020-10-15T23:05:11Z | OWNER | I think this should be a family of functions: - `instance_url()` - the root URL of the instance (usually `/` unless `base_url` is set) - `database_url(database_name)` - already got this - `table_url(database_name, table_name)` - `row_url(database_name, table_name, row)` - not sure about this one. The idea would be for `row` to be correctly turned into a URL by introspecting the primary keys for that table, then pulling those values out of the SQLite `row` object. Might not be necessary though. I also need a way for plugins to link to e.g. `/-/configure-fts` - or even `/-/configure-fts/database-name/table-name`. What should that look like? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
663228985 | |
https://github.com/simonw/datasette/issues/904#issuecomment-709634261 | https://api.github.com/repos/simonw/datasette/issues/904 | 709634261 | MDEyOklzc3VlQ29tbWVudDcwOTYzNDI2MQ== | 9599 | 2020-10-15T23:02:43Z | 2020-10-15T23:02:43Z | OWNER | Here's the current implementation of `database_url` - on the `BaseView` class, but only because it needs access to a `datasette` instance (to read `base_url`): https://github.com/simonw/datasette/blob/8f97b9b58e77f82fef1f10e9c9f6754b993544b6/datasette/views/base.py#L102-L108 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
663228985 | |
https://github.com/simonw/datasette/issues/904#issuecomment-709633823 | https://api.github.com/repos/simonw/datasette/issues/904 | 709633823 | MDEyOklzc3VlQ29tbWVudDcwOTYzMzgyMw== | 9599 | 2020-10-15T23:01:13Z | 2020-10-15T23:01:13Z | OWNER | Tracking ticket: #1023 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
663228985 |