github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/939#issuecomment-674548163 | https://api.github.com/repos/simonw/datasette/issues/939 | 674548163 | MDEyOklzc3VlQ29tbWVudDY3NDU0ODE2Mw== | 9599 | 2020-08-16T16:34:30Z | 2020-08-16T16:34:30Z | OWNER | Docs also need to note that `request` may be `None` for all of these hooks. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
679779797 | |
https://github.com/simonw/datasette/issues/939#issuecomment-674547811 | https://api.github.com/repos/simonw/datasette/issues/939 | 674547811 | MDEyOklzc3VlQ29tbWVudDY3NDU0NzgxMQ== | 9599 | 2020-08-16T16:31:20Z | 2020-08-16T16:31:20Z | OWNER | And the docs need to be updated too. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
679779797 | |
https://github.com/simonw/datasette/issues/939#issuecomment-674547788 | https://api.github.com/repos/simonw/datasette/issues/939 | 674547788 | MDEyOklzc3VlQ29tbWVudDY3NDU0Nzc4OA== | 9599 | 2020-08-16T16:31:08Z | 2020-08-16T16:31:08Z | OWNER | Also: they should all be able to return `async def` inner functions. At the moment only `extra_template_vars` supports that pattern. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
679779797 | |
https://github.com/simonw/datasette/issues/939#issuecomment-674545058 | https://api.github.com/repos/simonw/datasette/issues/939 | 674545058 | MDEyOklzc3VlQ29tbWVudDY3NDU0NTA1OA== | 9599 | 2020-08-16T16:07:20Z | 2020-08-16T16:07:20Z | OWNER | I'm going to implement this first as a single commit, then implement `columns` from #938 as a separate change. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
679779797 | |
https://github.com/simonw/datasette/issues/939#issuecomment-674544973 | https://api.github.com/repos/simonw/datasette/issues/939 | 674544973 | MDEyOklzc3VlQ29tbWVudDY3NDU0NDk3Mw== | 9599 | 2020-08-16T16:06:34Z | 2020-08-16T16:06:34Z | OWNER | They should also be next to each other in the documentation - right now they're a bit scattered in terms of page order: <img width="598" alt="Plugin_hooks_—_Datasette_documentation" src="https://user-images.githubusercontent.com/9599/90338620-c5d3af00-df9f-11ea-908b-3f888947dd03.png"> | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
679779797 | |
https://github.com/simonw/datasette/issues/939#issuecomment-674544875 | https://api.github.com/repos/simonw/datasette/issues/939 | 674544875 | MDEyOklzc3VlQ29tbWVudDY3NDU0NDg3NQ== | 9599 | 2020-08-16T16:05:36Z | 2020-08-16T16:05:36Z | OWNER | They should all take: template, database, table, view_name, request, datasette, columns `columns` is new, see #938. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
679779797 |