github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/996#issuecomment-705119801 | https://api.github.com/repos/simonw/datasette/issues/996 | 705119801 | MDEyOklzc3VlQ29tbWVudDcwNTExOTgwMQ== | 9599 | 2020-10-07T18:34:58Z | 2020-10-07T18:34:58Z | OWNER | One option: compare the length of the matches and pick the shortest one. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
716756082 | |
https://github.com/simonw/datasette/issues/996#issuecomment-705116123 | https://api.github.com/repos/simonw/datasette/issues/996 | 705116123 | MDEyOklzc3VlQ29tbWVudDcwNTExNjEyMw== | 9599 | 2020-10-07T18:27:57Z | 2020-10-07T18:28:36Z | OWNER | This line was meant to handle this case, by only matching non-/ characters. Looks like it did not have the desired effect: https://github.com/simonw/datasette/blob/14982bd900f17a66acc3930ec1a2ff138716d198/datasette/app.py#L1204 Maybe because the finished regex doesn't include `^` and `$` anchors? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
716756082 | |
https://github.com/simonw/datasette/issues/996#issuecomment-705115185 | https://api.github.com/repos/simonw/datasette/issues/996 | 705115185 | MDEyOklzc3VlQ29tbWVudDcwNTExNTE4NQ== | 9599 | 2020-10-07T18:26:11Z | 2020-10-07T18:26:45Z | OWNER | Relevant code: https://github.com/simonw/datasette/blob/14982bd900f17a66acc3930ec1a2ff138716d198/datasette/app.py#L1030-L1037 https://github.com/simonw/datasette/blob/14982bd900f17a66acc3930ec1a2ff138716d198/datasette/app.py#L951-L954 https://github.com/simonw/datasette/blob/14982bd900f17a66acc3930ec1a2ff138716d198/datasette/app.py#L1197-L1207 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
716756082 |