github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1003#issuecomment-706302863 | https://api.github.com/repos/simonw/datasette/issues/1003 | 706302863 | MDEyOklzc3VlQ29tbWVudDcwNjMwMjg2Mw== | 649467 | 2020-10-09T17:17:06Z | 2020-10-09T17:17:06Z | NONE | I agree on the descriptive and python-consistent naming. There is already a tojson, but frankly i find the "to" and "from" confusing in a text templating language where what's a string and what's data isn't 100% transparent. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
718238967 | |
https://github.com/simonw/datasette/issues/1003#issuecomment-706281451 | https://api.github.com/repos/simonw/datasette/issues/1003 | 706281451 | MDEyOklzc3VlQ29tbWVudDcwNjI4MTQ1MQ== | 9599 | 2020-10-09T16:33:01Z | 2020-10-09T16:33:01Z | OWNER | I think `json_dumps()` and `json_loads()` as aliases for `json.dumps()` and `json.loads()` is the way to go here. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
718238967 | |
https://github.com/simonw/datasette/issues/1003#issuecomment-706273211 | https://api.github.com/repos/simonw/datasette/issues/1003 | 706273211 | MDEyOklzc3VlQ29tbWVudDcwNjI3MzIxMQ== | 9599 | 2020-10-09T16:16:38Z | 2020-10-09T16:16:38Z | OWNER | I'm not a huge fan of `from_json` as the name for this. Some other options: - Expose `json` directly so templates can do `json.loads()` and `json.dumps()` - this allows for outputting JSON too, which is useful. But is there anything else on the `json` module that shouldn't be exposed in templates? - `json_dumps()` and `json_loads()` template functions. I quite like that. - Something else? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
718238967 | |
https://github.com/simonw/datasette/issues/1003#issuecomment-706272322 | https://api.github.com/repos/simonw/datasette/issues/1003 | 706272322 | MDEyOklzc3VlQ29tbWVudDcwNjI3MjMyMg== | 9599 | 2020-10-09T16:14:56Z | 2020-10-09T16:14:56Z | OWNER | Yes I think that makes sense. I added `json` to the template context in Dogsheep Beta just a few days ago because I needed that: https://github.com/dogsheep/dogsheep-beta/blob/bed9df2b3ef68189e2e445427721a28f4e9b4887/dogsheep_beta/__init__.py#L176 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
718238967 |