github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1035#issuecomment-712976314 | https://api.github.com/repos/simonw/datasette/issues/1035 | 712976314 | MDEyOklzc3VlQ29tbWVudDcxMjk3NjMxNA== | 9599 | 2020-10-20T16:21:42Z | 2020-10-20T16:21:42Z | OWNER | Makes me question if `datasette.urls` should grow functionality equivalent to the other path and querystring manipulation methods in `datasette.utils`: https://github.com/simonw/datasette/blob/66120a7a1cb592e8a21164cf537f62a4d7ab1dfc/datasette/utils/__init__.py#L216-L279 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
725743755 | |
https://github.com/simonw/datasette/issues/1035#issuecomment-712965574 | https://api.github.com/repos/simonw/datasette/issues/1035 | 712965574 | MDEyOklzc3VlQ29tbWVudDcxMjk2NTU3NA== | 9599 | 2020-10-20T16:13:57Z | 2020-10-20T16:13:57Z | OWNER | That `renderers[key] = path_with_format(` is in a base class which can be used for both arbitrary queries, canned queries and the table view. I think that's OK, but it means that the `format="json"` argument on `datasette.urls.table()` won't be used by Datasette internally, it will just be available for plugins. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
725743755 | |
https://github.com/simonw/datasette/issues/1035#issuecomment-712963959 | https://api.github.com/repos/simonw/datasette/issues/1035 | 712963959 | MDEyOklzc3VlQ29tbWVudDcxMjk2Mzk1OQ== | 9599 | 2020-10-20T16:11:25Z | 2020-10-20T16:11:25Z | OWNER | Relevant code: https://github.com/simonw/datasette/blob/091441a4449beae559a8c0d007376dc85d3aa624/datasette/utils/__init__.py#L681-L696 Only used here: https://github.com/simonw/datasette/blob/091441a4449beae559a8c0d007376dc85d3aa624/datasette/views/base.py#L498-L502 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
725743755 |