github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1067#issuecomment-719966176 | https://api.github.com/repos/simonw/datasette/issues/1067 | 719966176 | MDEyOklzc3VlQ29tbWVudDcxOTk2NjE3Ng== | 9599 | 2020-10-31T17:51:31Z | 2020-10-31T17:51:31Z | OWNER | Demo: - https://latest.datasette.io/fixtures/facetable?_bot=1 - https://latest.datasette.io/fixtures/simple_view?_bot=1 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
732905360 | |
https://github.com/simonw/datasette/issues/1067#issuecomment-719959419 | https://api.github.com/repos/simonw/datasette/issues/1067 | 719959419 | MDEyOklzc3VlQ29tbWVudDcxOTk1OTQxOQ== | 9599 | 2020-10-31T16:53:42Z | 2020-10-31T16:53:42Z | OWNER | For the 0.51 release I'm going to add tests that show this works on view pages. I won't implement it for query pages. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
732905360 | |
https://github.com/simonw/datasette/issues/1067#issuecomment-719961701 | https://api.github.com/repos/simonw/datasette/issues/1067 | 719961701 | MDEyOklzc3VlQ29tbWVudDcxOTk2MTcwMQ== | 9599 | 2020-10-31T17:11:59Z | 2020-10-31T17:11:59Z | OWNER | It bothers me that these aren't visible in any public demos. Maybe `latest.datasette.io` should include the `my_plugins.py` and `my_plugins2.py` plugins? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
732905360 | |
https://github.com/simonw/datasette/issues/1067#issuecomment-719322666 | https://api.github.com/repos/simonw/datasette/issues/1067 | 719322666 | MDEyOklzc3VlQ29tbWVudDcxOTMyMjY2Ng== | 9599 | 2020-10-30T07:04:02Z | 2020-10-30T07:04:02Z | OWNER | Maybe rename it to `actions_menu` and have it work for database, view, table and query pages using different arguments on each. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
732905360 | |
https://github.com/simonw/datasette/issues/1067#issuecomment-719956184 | https://api.github.com/repos/simonw/datasette/issues/1067 | 719956184 | MDEyOklzc3VlQ29tbWVudDcxOTk1NjE4NA== | 9599 | 2020-10-31T16:26:09Z | 2020-10-31T16:26:09Z | OWNER | Should the hook provide an indication that it's running on a different type of page? I think yes for queries. Not sure about views - they behave very much like tables, and the plugin can always introspect to see if something is a view if it needs to. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
732905360 | |
https://github.com/simonw/datasette/issues/1067#issuecomment-719320948 | https://api.github.com/repos/simonw/datasette/issues/1067 | 719320948 | MDEyOklzc3VlQ29tbWVudDcxOTMyMDk0OA== | 9599 | 2020-10-30T07:02:37Z | 2020-10-30T07:02:37Z | OWNER | Yes, this should be possible - no point restricting what plugin authors can do with the feature. Will need to add some extra arguments to the plugin hook for this. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
732905360 |