github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1107#issuecomment-733241949 | https://api.github.com/repos/simonw/datasette/issues/1107 | 733241949 | MDEyOklzc3VlQ29tbWVudDczMzI0MTk0OQ== | 9599 | 2020-11-24T21:24:26Z | 2020-11-24T21:24:26Z | OWNER | Are there any plugins that use this API even though it isn't documented? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
750079085 | |
https://github.com/simonw/datasette/issues/1107#issuecomment-733261501 | https://api.github.com/repos/simonw/datasette/issues/1107 | 733261501 | MDEyOklzc3VlQ29tbWVudDczMzI2MTUwMQ== | 9599 | 2020-11-24T22:09:11Z | 2020-11-24T22:09:11Z | OWNER | Documentation: https://docs.datasette.io/en/latest/internals.html#setting-key | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
750079085 | |
https://github.com/simonw/datasette/issues/1107#issuecomment-733244471 | https://api.github.com/repos/simonw/datasette/issues/1107 | 733244471 | MDEyOklzc3VlQ29tbWVudDczMzI0NDQ3MQ== | 9599 | 2020-11-24T21:29:59Z | 2020-11-24T21:29:59Z | OWNER | I ran `rg '.config\(' datasette-*/` in my top-level directory: ``` datasette-sentry/test_datasette_sentry.py: def plugin_config(self, name): datasette-sentry/datasette_sentry.py: config = datasette.plugin_config("datasette-sentry") or {} datasette-render-markdown/datasette_render_markdown/__init__.py: datasette.plugin_config( datasette-render-images/datasette_render_images.py: plugin_config = datasette.plugin_config("datasette-render-images") or {} datasette-render-html/datasette_render_html.py: config = datasette.plugin_config( datasette-render-timestamps/datasette_render_timestamps/__init__.py: datasette.plugin_config( datasette-permissions-sql/datasette_permissions_sql/__init__.py: for rule in datasette.plugin_config("datasette-permissions-sql") or []: datasette-mask-columns/datasette_mask_columns/__init__.py: datasette.plugin_config("datasette-mask-columns", database=database) or {} datasette-mask-columns/datasette_mask_columns/__init__.py: masks = datasette.plugin_config("datasette-mask-columns", database=database) or {} datasette-media/datasette_media/__init__.py: plugin_config = datasette.plugin_config("datasette-media") or {} datasette-insert/datasette_insert/__init__.py: plugin_config = datasette.plugin_config("datasette-insert") or {} datasette-indieauth/datasette_indieauth/__init__.py: plugin_config = datasette.plugin_config("datasette-indieauth") or {} datasette-graphql/datasette_graphql/__init__.py: config = datasette.plugin_config("datasette-graphql") or {} datasette-graphql/datasette_graphql/__init__.py: config = datasette.plugin_config("datasette-graphql") or {} datasette-graphql/datasette_graphql/utils.py: auto_camelcase=(datasette.plugin_config("datasette-graphql") or {}).get( datasette-graphql/datasette_graphql/utils.py: table_plugin_config = datasette.plugin_config( datasette-graphql/datasette_graphql/utils.py: def config(self, key): datasette-graphql/datasette_graphql/utils.py: return … | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
750079085 | |
https://github.com/simonw/datasette/issues/1107#issuecomment-733257071 | https://api.github.com/repos/simonw/datasette/issues/1107 | 733257071 | MDEyOklzc3VlQ29tbWVudDczMzI1NzA3MQ== | 9599 | 2020-11-24T21:59:32Z | 2020-11-24T21:59:32Z | OWNER | I'm going to make this a documented method in https://docs.datasette.io/en/latest/internals.html#datasette-class | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
750079085 | |
https://github.com/simonw/datasette/issues/1107#issuecomment-733245097 | https://api.github.com/repos/simonw/datasette/issues/1107 | 733245097 | MDEyOklzc3VlQ29tbWVudDczMzI0NTA5Nw== | 9599 | 2020-11-24T21:31:10Z | 2020-11-24T21:31:10Z | OWNER | Most of these use `plugin_config` which is unaffected. It looks like the only code I need to worry about is this trick in `datasette-graphl`: https://github.com/simonw/datasette-graphql/blob/483c9a9e203bb90365def3df8b8f01dda1e75865/datasette_graphql/utils.py#L456-L460 ```python class DatasetteSpecialConfig(wrapt.ObjectProxy): def config(self, key): if key == "suggest_facets": return False return self.__wrapped__.config(key) ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
750079085 |