github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1391#issuecomment-877691558 | https://api.github.com/repos/simonw/datasette/issues/1391 | 877691558 | MDEyOklzc3VlQ29tbWVudDg3NzY5MTU1OA== | 9599 | 2021-07-10T19:26:57Z | 2021-07-10T19:26:57Z | OWNER | The `https://latest.datasette.io/fixtures.db` file no longer includes generated columns, which will help avoid confusion such as seen in #1376. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
941300946 | |
https://github.com/simonw/datasette/issues/1391#issuecomment-877691427 | https://api.github.com/repos/simonw/datasette/issues/1391 | 877691427 | MDEyOklzc3VlQ29tbWVudDg3NzY5MTQyNw== | 9599 | 2021-07-10T19:26:00Z | 2021-07-10T19:26:00Z | OWNER | I had to run the tests locally on my macOS laptop using `pysqlite3` to get a version that supported generated columns - wrote up a TIL about that here: https://til.simonwillison.net/sqlite/pysqlite3-on-macos | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
941300946 | |
https://github.com/simonw/datasette/issues/1391#issuecomment-877687196 | https://api.github.com/repos/simonw/datasette/issues/1391 | 877687196 | MDEyOklzc3VlQ29tbWVudDg3NzY4NzE5Ng== | 9599 | 2021-07-10T18:58:40Z | 2021-07-10T18:58:40Z | OWNER | I can use the `extra_databases` mechanism as demonstrated here: https://github.com/simonw/datasette/blob/9552414e1f968c6fc704031cec349c05e6bc2371/tests/test_canned_queries.py#L8-L12 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
941300946 | |
https://github.com/simonw/datasette/issues/1391#issuecomment-877686784 | https://api.github.com/repos/simonw/datasette/issues/1391 | 877686784 | MDEyOklzc3VlQ29tbWVudDg3NzY4Njc4NA== | 9599 | 2021-07-10T18:56:03Z | 2021-07-10T18:56:03Z | OWNER | Here's the SQL used to generate the table for the test: https://github.com/simonw/datasette/blob/02b19c7a9afd328f22040ab33b5c1911cd904c7c/tests/fixtures.py#L723-L733 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
941300946 | |
https://github.com/simonw/datasette/issues/1391#issuecomment-877682533 | https://api.github.com/repos/simonw/datasette/issues/1391 | 877682533 | MDEyOklzc3VlQ29tbWVudDg3NzY4MjUzMw== | 9599 | 2021-07-10T18:28:05Z | 2021-07-10T18:28:05Z | OWNER | Here's the test in question: https://github.com/simonw/datasette/blob/a6c55afe8c82ead8deb32f90c9324022fd422324/tests/test_api.py#L2033-L2046 Various other places in the test code also need changing - anything that calls `supports_generated_columns()`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
941300946 |