github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/2165#issuecomment-1699910555 | https://api.github.com/repos/simonw/datasette/issues/2165 | 1699910555 | IC_kwDOBm6k_c5lUpOb | 9599 | 2023-08-30T22:05:14Z | 2023-08-30T22:05:14Z | OWNER | Documentation preview: https://github.com/simonw/datasette/blob/6321c9c055a640ed6ea98e231dc5813dcde1f773/docs/plugins.rst#controlling-which-plugins-are-loaded | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1874327336 | |
https://github.com/simonw/datasette/pull/2165#issuecomment-1699884314 | https://api.github.com/repos/simonw/datasette/issues/2165 | 1699884314 | IC_kwDOBm6k_c5lUi0a | 9599 | 2023-08-30T21:38:29Z | 2023-08-30T21:39:51Z | OWNER | Here's the reason for that name disparity: https://github.com/simonw/datasette/blob/30b28c8367a9c6870386ea10a202705b40862457/datasette/plugins.py#L54-L65 Note how the `distinfo.project_name` name is used when available. That seems to work for regularly installed plugins but not for plugins loaded via `DATASETTE_LOAD_PLUGINS`. And that's looking things up in `plugin_to_distinfo` which is populated here: https://github.com/simonw/datasette/blob/30b28c8367a9c6870386ea10a202705b40862457/datasette/plugins.py#L37 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1874327336 | |
https://github.com/simonw/datasette/pull/2165#issuecomment-1699811810 | https://api.github.com/repos/simonw/datasette/issues/2165 | 1699811810 | IC_kwDOBm6k_c5lURHi | 9599 | 2023-08-30T20:42:41Z | 2023-08-30T20:42:41Z | OWNER | The `load_setuptools_entrypoints()` function in Pluggy [does this](https://github.com/pytest-dev/pluggy/blob/0b41c9766508a46ae666cf281684df3164b3e2a9/src/pluggy/_manager.py#L376): ```python for ep in dist.entry_points: if ( ep.group != group or (name is not None and ep.name != name) # already registered or self.get_plugin(ep.name) or self.is_blocked(ep.name) ): continue plugin = ep.load() self.register(plugin, name=ep.name) ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1874327336 | |
https://github.com/simonw/datasette/pull/2165#issuecomment-1699809688 | https://api.github.com/repos/simonw/datasette/issues/2165 | 1699809688 | IC_kwDOBm6k_c5lUQmY | 9599 | 2023-08-30T20:41:06Z | 2023-08-30T20:41:06Z | OWNER | Slight weirdness: I noticed that the output from the `datasette plugins` command looks like this for plugins loaded with the new environment variable: ```json { "name": "datasette_pretty_json", "static": false, "templates": false, "version": null, "hooks": [ "render_cell" ] }, ``` That should ideally be `datasette-pretty-json`, not `datasette_pretty_json`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1874327336 | |
https://github.com/simonw/datasette/pull/2165#issuecomment-1699802028 | https://api.github.com/repos/simonw/datasette/issues/2165 | 1699802028 | IC_kwDOBm6k_c5lUOus | 9599 | 2023-08-30T20:35:02Z | 2023-08-30T20:35:02Z | OWNER | Testing this is going to be a bit of a pain. I think I'll add a whole separate test block to CI which installs a couple of plugins and then exercises this feature using `datasette plugins`. I'll use `datasette-init` and `datasette-json-html` just because they are small and simple. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1874327336 |