github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/203#issuecomment-381348849 | https://api.github.com/repos/simonw/datasette/issues/203 | 381348849 | MDEyOklzc3VlQ29tbWVudDM4MTM0ODg0OQ== | 9599 | 2018-04-14T18:12:52Z | 2018-04-14T18:12:52Z | OWNER | I think I'm going to hold on to the custom sql function idea for the moment and implement it as an example plugin. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
313837303 | |
https://github.com/simonw/datasette/pull/205#issuecomment-381336696 | https://api.github.com/repos/simonw/datasette/issues/205 | 381336696 | MDEyOklzc3VlQ29tbWVudDM4MTMzNjY5Ng== | 9599 | 2018-04-14T15:24:04Z | 2018-04-14T15:24:04Z | OWNER | I merged this to master in c857608738d6b6c3e4f3248304a22f8b2648dd3e - thanks @russss! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
314319372 | |
https://github.com/simonw/datasette/pull/207#issuecomment-381334973 | https://api.github.com/repos/simonw/datasette/issues/207 | 381334973 | MDEyOklzc3VlQ29tbWVudDM4MTMzNDk3Mw== | 9599 | 2018-04-14T14:59:52Z | 2018-04-14T14:59:52Z | OWNER | I'm going to merge this and then add a unit test. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
314329002 | |
https://github.com/simonw/datasette/pull/205#issuecomment-381330220 | https://api.github.com/repos/simonw/datasette/issues/205 | 381330220 | MDEyOklzc3VlQ29tbWVudDM4MTMzMDIyMA== | 9599 | 2018-04-14T13:44:15Z | 2018-04-14T13:44:15Z | OWNER | This looks great so far - love the new documentation. Let's throw in a unit test or two for the basic unit filters (mainly as a protection against accidental regressions in the future). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
314319372 | |
https://github.com/simonw/datasette/issues/203#issuecomment-381330075 | https://api.github.com/repos/simonw/datasette/issues/203 | 381330075 | MDEyOklzc3VlQ29tbWVudDM4MTMzMDA3NQ== | 9599 | 2018-04-14T13:41:53Z | 2018-04-14T13:41:53Z | OWNER | Presumably units only work for numeric fields? If that's the case then automatically processing them if the incoming query string argument has a unit suffix makes total sense to me. Here's a pretty crazy idea: what if we exposed unit conversion to SQL as a custom SQLite function? That way it would be possible to optionally use units in actual custom SQL queries. I'd have to think quite carefully about performance implications here - wouldn't want a poorly considered unit calculation over a 500,000 row table to lock up the server. But I think the 1s query time limit might still prevent that. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
313837303 | |
https://github.com/simonw/datasette/issues/203#issuecomment-381300386 | https://api.github.com/repos/simonw/datasette/issues/203 | 381300386 | MDEyOklzc3VlQ29tbWVudDM4MTMwMDM4Ng== | 9599 | 2018-04-14T03:35:56Z | 2018-04-14T03:35:56Z | OWNER | In #204 you said "I'd like to add support for using units when querying but this is PR is pretty usable as-is." - I'm fascinated to hear more about how this could work. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
313837303 | |
https://github.com/simonw/datasette/issues/203#issuecomment-381300336 | https://api.github.com/repos/simonw/datasette/issues/203 | 381300336 | MDEyOklzc3VlQ29tbWVudDM4MTMwMDMzNg== | 9599 | 2018-04-14T03:35:02Z | 2018-04-14T03:35:02Z | OWNER | This is really cool - I'm very impressed by pint. I'd like to figure out a sensible opt-in way to expose this in the JSON output as well. Maybe with a `&_units=true` parameter? We should definitely expose the units section from the table metadata in the output of https://wtr-api.herokuapp.com/wtr-663ea99/license_frequency.json | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
313837303 |