github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/418#issuecomment-491551702 | https://api.github.com/repos/simonw/datasette/issues/418 | 491551702 | MDEyOklzc3VlQ29tbWVudDQ5MTU1MTcwMg== | 9599 | 2019-05-11T23:32:21Z | 2019-05-11T23:32:21Z | OWNER | I'm going to re-open this, because some of this needs revisiting now that we aren't running `.inspect()` and hence are not calculating hashes for anything other than immutable databases (and databases are treated as mutable by default). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
421548881 | |
https://github.com/simonw/datasette/issues/418#issuecomment-491551647 | https://api.github.com/repos/simonw/datasette/issues/418 | 491551647 | MDEyOklzc3VlQ29tbWVudDQ5MTU1MTY0Nw== | 9599 | 2019-05-11T23:31:23Z | 2019-05-11T23:31:23Z | OWNER | Actually right now https://latest.datasette.io/fixtures/facetable?_hash=1 redirects to https://latest.datasette.io/fixtures-000/facetable - because we are no longer calculating hashes on startup for non-immutable databases. So that's weird. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
421548881 | |
https://github.com/simonw/datasette/issues/466#issuecomment-491549929 | https://api.github.com/repos/simonw/datasette/issues/466 | 491549929 | MDEyOklzc3VlQ29tbWVudDQ5MTU0OTkyOQ== | 9599 | 2019-05-11T22:55:23Z | 2019-05-11T22:55:23Z | OWNER | To build a unit test for this I'm going to have to ship a small spatialite.db binary database as part of the git repo. This is because I need the tests to run even when the spatialite module is not available - but you cannot create a spatialite database without having access to that module. I'll include a build script in the repo for constructing that database. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
443040665 | |
https://github.com/simonw/datasette/issues/466#issuecomment-491548189 | https://api.github.com/repos/simonw/datasette/issues/466 | 491548189 | MDEyOklzc3VlQ29tbWVudDQ5MTU0ODE4OQ== | 9599 | 2019-05-11T22:21:40Z | 2019-05-11T22:21:47Z | OWNER | This is a little bit tricky. This SQL looks like it may detect Spatialite tables: ```sql select * from sqlite_master where type = "table" and sql like "%CREATE VIRTUAL TABLE%" and sql like "%USING VirtualSpatialIndex%" ``` But where to put it? I think this should go in a new "checks" mechanism, where we run checks against every connected database on Datasette startup. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
443040665 | |
https://github.com/simonw/datasette/issues/462#issuecomment-491545952 | https://api.github.com/repos/simonw/datasette/issues/462 | 491545952 | MDEyOklzc3VlQ29tbWVudDQ5MTU0NTk1Mg== | 9599 | 2019-05-11T21:41:49Z | 2019-05-11T21:41:49Z | OWNER | I now need to update `datasette serve ... --inspect-data=X` to understand and correctly handle the new format. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
443023308 | |
https://github.com/simonw/datasette/issues/295#issuecomment-491545892 | https://api.github.com/repos/simonw/datasette/issues/295 | 491545892 | MDEyOklzc3VlQ29tbWVudDQ5MTU0NTg5Mg== | 9599 | 2019-05-11T21:40:32Z | 2019-05-11T21:40:32Z | OWNER | I'm not going to do this, as a result of #462 and #419 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
327383759 | |
https://github.com/simonw/datasette/issues/465#issuecomment-491545872 | https://api.github.com/repos/simonw/datasette/issues/465 | 491545872 | MDEyOklzc3VlQ29tbWVudDQ5MTU0NTg3Mg== | 9599 | 2019-05-11T21:40:07Z | 2019-05-11T21:40:07Z | OWNER | I split this out from #462 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
443038584 | |
https://github.com/simonw/datasette/issues/462#issuecomment-491543817 | https://api.github.com/repos/simonw/datasette/issues/462 | 491543817 | MDEyOklzc3VlQ29tbWVudDQ5MTU0MzgxNw== | 9599 | 2019-05-11T21:06:13Z | 2019-05-11T21:06:13Z | OWNER | I'm going to change it to output to stdout unless you pass it the `--inspect-file` argument. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
443023308 | |
https://github.com/simonw/datasette/issues/462#issuecomment-491543785 | https://api.github.com/repos/simonw/datasette/issues/462 | 491543785 | MDEyOklzc3VlQ29tbWVudDQ5MTU0Mzc4NQ== | 9599 | 2019-05-11T21:05:54Z | 2019-05-11T21:05:54Z | OWNER | So I think `datasette inspect fixtures.db other.db` should output something like this: ```json { "fixtures": { "hash": "894870db97229e9e18b40921dc32b581da813465d672445e96e040ab2adbd229", "file": "fixtures.db", "size": 225280, "tables": { "facetable": { "count": 34, } } } ``` It currently writes it out to a file called `inspect-data.json`. Should I keep that as the default behaviour or switch it to outputting to stdout instead? Here's the current `datasette inspect --help`: ```$ datasette inspect --help Usage: datasette inspect [OPTIONS] [FILES]... Options: --inspect-file TEXT --load-extension PATH Path to a SQLite extension to load --help Show this message and exit.``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
443023308 | |
https://github.com/simonw/datasette/issues/462#issuecomment-491543635 | https://api.github.com/repos/simonw/datasette/issues/462 | 491543635 | MDEyOklzc3VlQ29tbWVudDQ5MTU0MzYzNQ== | 9599 | 2019-05-11T21:03:10Z | 2019-05-11T21:03:23Z | OWNER | `test_inspect.py` currently just contains two tests that exercise a small portion of what `.inspect()` does - I'm going to repurpose that module and have it only test the `datasette inspect` CLI command instead. Here's the current contents of that file: https://github.com/simonw/datasette/blob/ce09e5d2d392634eced44c3c8d603d7c628e2822/tests/test_inspect.py | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
443023308 | |
https://github.com/simonw/datasette/issues/435#issuecomment-491541721 | https://api.github.com/repos/simonw/datasette/issues/435 | 491541721 | MDEyOklzc3VlQ29tbWVudDQ5MTU0MTcyMQ== | 9599 | 2019-05-11T20:32:21Z | 2019-05-11T20:32:21Z | OWNER | Demo of the finished feature: https://latest.datasette.io/fixtures/facetable?_trace=1 <img width="1294" alt="image" src="https://user-images.githubusercontent.com/9599/57574617-2ebd9600-73f1-11e9-9a1a-458f1b7d0d66.png"> | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
435531034 | |
https://github.com/simonw/datasette/issues/459#issuecomment-491533931 | https://api.github.com/repos/simonw/datasette/issues/459 | 491533931 | MDEyOklzc3VlQ29tbWVudDQ5MTUzMzkzMQ== | 9599 | 2019-05-11T18:29:37Z | 2019-05-11T19:26:11Z | OWNER | This needs doing before the next release because it is interfering with my Travis code that actually runs the release: https://travis-ci.org/simonw/datasette/jobs/530597261 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
443020048 | |
https://github.com/simonw/datasette/issues/460#issuecomment-491536725 | https://api.github.com/repos/simonw/datasette/issues/460 | 491536725 | MDEyOklzc3VlQ29tbWVudDQ5MTUzNjcyNQ== | 9599 | 2019-05-11T19:11:44Z | 2019-05-11T19:11:44Z | OWNER | I split pagination out to #461 - and I don't consider that necessary to ship the next release. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
443020810 | |
https://github.com/simonw/datasette/issues/435#issuecomment-491534162 | https://api.github.com/repos/simonw/datasette/issues/435 | 491534162 | MDEyOklzc3VlQ29tbWVudDQ5MTUzNDE2Mg== | 9599 | 2019-05-11T18:33:02Z | 2019-05-11T18:36:33Z | OWNER | I don't like the shape of the JSON: ``` "_traces": { "num_traces": 20, "traces": { "duration": 0.015190839767456055, "queries": [ [ "sql", [ "fixtures", "select 1 from sqlite_master where type='table' and name=?", [ "facetable.json" ] ], 1557599406.7231224, 1557599406.723611, 0.4887580871582031 ], [ ``` I want this instead: ``` "_traces": { "num_traces": 20, "sum_duration_ms": 0.015190839767456055, "traces": [ { "type": "sql", "database": "fixtures", "sql": "select 1 from sqlite_master where type='table' and name=?", "args": ["facetable.json"], "start": 1557599406.7231224, "end": 1557599406.723611, "duration_ms": 0.4887580871582031 } | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
435531034 | |
https://github.com/simonw/datasette/issues/316#issuecomment-491533700 | https://api.github.com/repos/simonw/datasette/issues/316 | 491533700 | MDEyOklzc3VlQ29tbWVudDQ5MTUzMzcwMA== | 9599 | 2019-05-11T18:26:25Z | 2019-05-11T18:26:25Z | OWNER | This will be fixed by #419 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
333238932 | |
https://github.com/simonw/datasette/pull/450#issuecomment-491532671 | https://api.github.com/repos/simonw/datasette/issues/450 | 491532671 | MDEyOklzc3VlQ29tbWVudDQ5MTUzMjY3MQ== | 9599 | 2019-05-11T18:10:09Z | 2019-05-11T18:10:09Z | OWNER | I fixed this in https://github.com/simonw/datasette/commit/de005b9b7d3db72375e6b8b048d1616a98e6347a instead (hadn't seen this PR) | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
440304714 | |
https://github.com/simonw/datasette/issues/373#issuecomment-491532557 | https://api.github.com/repos/simonw/datasette/issues/373 | 491532557 | MDEyOklzc3VlQ29tbWVudDQ5MTUzMjU1Nw== | 9599 | 2019-05-11T18:08:47Z | 2019-05-11T18:08:47Z | OWNER | I'll do this as part of #460 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
377266351 | |
https://github.com/simonw/datasette/issues/461#issuecomment-491532380 | https://api.github.com/repos/simonw/datasette/issues/461 | 491532380 | MDEyOklzc3VlQ29tbWVudDQ5MTUzMjM4MA== | 9599 | 2019-05-11T18:06:01Z | 2019-05-11T18:06:01Z | OWNER | I plan to add a search filter box too, but only if there are more than X (probably 10) connected databases. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
443021509 | |
https://github.com/simonw/datasette/issues/459#issuecomment-491531399 | https://api.github.com/repos/simonw/datasette/issues/459 | 491531399 | MDEyOklzc3VlQ29tbWVudDQ5MTUzMTM5OQ== | 9599 | 2019-05-11T17:51:11Z | 2019-05-11T17:51:11Z | OWNER | This is the publish code that needs updating: https://github.com/simonw/datasette/blob/e7b31ae8c1a28cab9db8e165b3f21407c2e581e6/datasette/publish/now.py#L79-L96 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
443020048 | |
https://github.com/simonw/datasette/issues/459#issuecomment-491531364 | https://api.github.com/repos/simonw/datasette/issues/459 | 491531364 | MDEyOklzc3VlQ29tbWVudDQ5MTUzMTM2NA== | 9599 | 2019-05-11T17:50:37Z | 2019-05-11T17:50:37Z | OWNER | I also need to fix my various `.travis.yml` configs to adapt to this new change. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
443020048 |