github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/775#issuecomment-635023389 | https://api.github.com/repos/simonw/datasette/issues/775 | 635023389 | MDEyOklzc3VlQ29tbWVudDYzNTAyMzM4OQ== | 9599 | 2020-05-28T00:47:32Z | 2020-05-28T00:47:32Z | OWNER | These: https://github.com/simonw/datasette/blob/4b96857f170e329a73186e703cc0d9ca4e8719cc/tests/fixtures.py#L337-L506 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626131309 | |
https://github.com/simonw/datasette/issues/645#issuecomment-635054690 | https://api.github.com/repos/simonw/datasette/issues/645 | 635054690 | MDEyOklzc3VlQ29tbWVudDYzNTA1NDY5MA== | 9599 | 2020-05-28T02:22:12Z | 2020-05-28T02:22:12Z | OWNER | This is a duplicate of a more recent, more developed issue: #770 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
530653633 | |
https://github.com/simonw/datasette/issues/581#issuecomment-635055346 | https://api.github.com/repos/simonw/datasette/issues/581 | 635055346 | MDEyOklzc3VlQ29tbWVudDYzNTA1NTM0Ng== | 9599 | 2020-05-28T02:24:14Z | 2020-05-28T02:24:14Z | OWNER | Updated documentation is here: https://datasette.readthedocs.io/en/latest/plugins.html#register-output-renderer-datasette | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
502993509 | |
https://github.com/simonw/datasette/issues/776#issuecomment-635056357 | https://api.github.com/repos/simonw/datasette/issues/776 | 635056357 | MDEyOklzc3VlQ29tbWVudDYzNTA1NjM1Nw== | 9599 | 2020-05-28T02:27:26Z | 2020-05-28T02:27:26Z | OWNER | Example code from elsewhere: https://github.com/simonw/datasette/blob/52c4387c7d37c867104e3728cc1f4c4d1e100642/datasette/views/base.py#L416-L420 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626163974 | |
https://github.com/simonw/datasette/issues/770#issuecomment-635056520 | https://api.github.com/repos/simonw/datasette/issues/770 | 635056520 | MDEyOklzc3VlQ29tbWVudDYzNTA1NjUyMA== | 9599 | 2020-05-28T02:28:00Z | 2020-05-28T02:28:00Z | OWNER | This should be optionally awaitable, as in #776 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
625930207 | |
https://github.com/simonw/datasette/issues/773#issuecomment-635069987 | https://api.github.com/repos/simonw/datasette/issues/773 | 635069987 | MDEyOklzc3VlQ29tbWVudDYzNTA2OTk4Nw== | 9599 | 2020-05-28T03:13:27Z | 2020-05-28T03:13:27Z | OWNER | `register_output_renderer` test added in https://github.com/simonw/datasette/commit/52c4387c7d37c867104e3728cc1f4c4d1e100642#diff-56f7d7b4778bac73b6b655c02c8467aaR336 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626001501 | |
https://github.com/simonw/datasette/issues/751#issuecomment-635101438 | https://api.github.com/repos/simonw/datasette/issues/751 | 635101438 | MDEyOklzc3VlQ29tbWVudDYzNTEwMTQzOA== | 9599 | 2020-05-28T05:00:21Z | 2020-05-28T05:00:21Z | OWNER | Documentation: https://datasette.readthedocs.io/en/latest/metadata.html#setting-a-custom-page-size | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
611540797 | |
https://github.com/simonw/datasette/issues/758#issuecomment-635102675 | https://api.github.com/repos/simonw/datasette/issues/758 | 635102675 | MDEyOklzc3VlQ29tbWVudDYzNTEwMjY3NQ== | 9599 | 2020-05-28T05:04:07Z | 2020-05-28T05:04:07Z | OWNER | @clausjuhl do you have any thoughts on what would be most useful for you in these JSON responses? The full `/databasename-hash` path, just the 7 character hash, or something else? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
612382643 | |
https://github.com/simonw/datasette/issues/706#issuecomment-635131217 | https://api.github.com/repos/simonw/datasette/issues/706 | 635131217 | MDEyOklzc3VlQ29tbWVudDYzNTEzMTIxNw== | 9599 | 2020-05-28T06:20:44Z | 2020-05-28T06:20:44Z | OWNER | Documentation: https://datasette.readthedocs.io/en/latest/sql_queries.html#canned-queries-default-fragment | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
585633142 | |
https://github.com/simonw/datasette/issues/744#issuecomment-635384739 | https://api.github.com/repos/simonw/datasette/issues/744 | 635384739 | MDEyOklzc3VlQ29tbWVudDYzNTM4NDczOQ== | 9599 | 2020-05-28T14:28:58Z | 2020-05-28T14:28:58Z | OWNER | This is now released. `pip install datasette==0.43` should get the fix. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
608058890 | |
https://github.com/simonw/datasette/issues/780#issuecomment-635413437 | https://api.github.com/repos/simonw/datasette/issues/780 | 635413437 | MDEyOklzc3VlQ29tbWVudDYzNTQxMzQzNw== | 9599 | 2020-05-28T15:15:03Z | 2020-05-28T15:15:03Z | OWNER | Also: I think I should add a `query=` parameter to help lookup metadata about a specific named canned query. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626593402 | |
https://github.com/simonw/datasette/issues/781#issuecomment-635468994 | https://api.github.com/repos/simonw/datasette/issues/781 | 635468994 | MDEyOklzc3VlQ29tbWVudDYzNTQ2ODk5NA== | 9599 | 2020-05-28T16:55:35Z | 2020-05-28T16:55:35Z | OWNER | I think the right way to fix this is to modify the `scope["scheme"]` ASGI key before the Request object is constructed - otherwise that Request class will have to gain knowledge of Datasette's configuration mechanism. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626663119 | |
https://github.com/simonw/datasette/issues/781#issuecomment-635471007 | https://api.github.com/repos/simonw/datasette/issues/781 | 635471007 | MDEyOklzc3VlQ29tbWVudDYzNTQ3MTAwNw== | 9599 | 2020-05-28T16:58:47Z | 2020-05-28T16:58:47Z | OWNER | I'm inclined to do this at the earliest possible moment. I think that's probably in the `DatasetteRouter` class, which should see every `scope` first and be able to apply that setting to it. It already has some special case logic to deal with the `base_url` setting here: https://github.com/simonw/datasette/blob/40885ef24e32d91502b6b8bbad1c7376f50f2830/datasette/app.py#L779-L789 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626663119 | |
https://github.com/simonw/datasette/issues/780#issuecomment-635480948 | https://api.github.com/repos/simonw/datasette/issues/780 | 635480948 | MDEyOklzc3VlQ29tbWVudDYzNTQ4MDk0OA== | 9599 | 2020-05-28T17:12:45Z | 2020-05-28T17:12:45Z | OWNER | This is a good opportunity to reconsider the design of this function and see if I'm happy with it as-is or if there are some improvements I want to make before adding it to the documented API. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626593402 | |
https://github.com/simonw/datasette/issues/781#issuecomment-635494730 | https://api.github.com/repos/simonw/datasette/issues/781 | 635494730 | MDEyOklzc3VlQ29tbWVudDYzNTQ5NDczMA== | 9599 | 2020-05-28T17:39:54Z | 2020-05-28T17:39:54Z | OWNER | https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fwww.niche-museums.com%2Fbrowse%2Ffeed.atom validates now! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626663119 | |
https://github.com/simonw/datasette/issues/774#issuecomment-635530876 | https://api.github.com/repos/simonw/datasette/issues/774 | 635530876 | MDEyOklzc3VlQ29tbWVudDYzNTUzMDg3Ng== | 9599 | 2020-05-28T18:50:18Z | 2020-05-28T18:50:18Z | OWNER | How about moving this functionality to the request object itself? ```python q = request["q"] # Raises KeyError if missing, otherwise returns first q = request.get("q", "default") # Returns first, or optional default or None facets = request.getlist("_facet") ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
626078521 | |
https://github.com/simonw/datasette/issues/508#issuecomment-635532216 | https://api.github.com/repos/simonw/datasette/issues/508 | 635532216 | MDEyOklzc3VlQ29tbWVudDYzNTUzMjIxNg== | 9599 | 2020-05-28T18:53:02Z | 2020-05-28T18:53:02Z | OWNER | I fixed this a while ago in #702: https://datasette.readthedocs.io/en/stable/metadata.html#setting-a-default-sort-order | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
455965174 | |
https://github.com/simonw/datasette/issues/351#issuecomment-635533807 | https://api.github.com/repos/simonw/datasette/issues/351 | 635533807 | MDEyOklzc3VlQ29tbWVudDYzNTUzMzgwNw== | 9599 | 2020-05-28T18:56:15Z | 2020-05-28T18:56:15Z | OWNER | I'm not going to do this. I have a good enough solution now pasting the rendered HTML from the release notes into https://euangoddard.github.io/clipboard2markdown/ to get the Markdown. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
345469355 |