github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/815#issuecomment-640673405 | https://api.github.com/repos/simonw/datasette/issues/815 | 640673405 | MDEyOklzc3VlQ29tbWVudDY0MDY3MzQwNQ== | 9599 | 2020-06-08T14:41:55Z | 2020-06-08T14:41:55Z | OWNER | I want to be able to display the HTTP path and verb - `GET /fixtures`, `POST /fixtures/myquery` etc. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
634663505 | |
https://github.com/simonw/datasette/issues/815#issuecomment-640673138 | https://api.github.com/repos/simonw/datasette/issues/815 | 640673138 | MDEyOklzc3VlQ29tbWVudDY0MDY3MzEzOA== | 9599 | 2020-06-08T14:41:24Z | 2020-06-08T14:41:24Z | OWNER | I could reuse that `get_task_id()` function though (I can move it to utils). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
634663505 | |
https://github.com/simonw/datasette/issues/815#issuecomment-640672540 | https://api.github.com/repos/simonw/datasette/issues/815 | 640672540 | MDEyOklzc3VlQ29tbWVudDY0MDY3MjU0MA== | 9599 | 2020-06-08T14:40:22Z | 2020-06-08T14:40:22Z | OWNER | Here's the current tracer mechanism. Note that it captures a stacktrace (which is expensive) - but only if the tracer system has been enabled for a request. https://github.com/simonw/datasette/blob/1c063fae9dba70f70244db010d55a18846640f07/datasette/tracer.py#L27-L51 For permissions checks I want to ALWAYS track those calls, not just on requests that have opted in. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
634663505 | |
https://github.com/simonw/datasette/issues/815#issuecomment-640671398 | https://api.github.com/repos/simonw/datasette/issues/815 | 640671398 | MDEyOklzc3VlQ29tbWVudDY0MDY3MTM5OA== | 9599 | 2020-06-08T14:38:20Z | 2020-06-08T14:38:20Z | OWNER | But `ds._permission_checks` is also used for unit tests. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
634663505 | |
https://github.com/simonw/datasette/issues/815#issuecomment-640671241 | https://api.github.com/repos/simonw/datasette/issues/815 | 640671241 | MDEyOklzc3VlQ29tbWVudDY0MDY3MTI0MQ== | 9599 | 2020-06-08T14:38:04Z | 2020-06-08T14:38:04Z | OWNER | Alternative to a correlation ID would be to use the existing `AsgiTracer` / `capture_traces` mechanism. That's probably smarter. It could even start logging SQL queries to an in-memory deque too, so a debug tool could show you queries executed by other requests! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
634663505 | |
https://github.com/simonw/datasette/issues/815#issuecomment-640656143 | https://api.github.com/repos/simonw/datasette/issues/815 | 640656143 | MDEyOklzc3VlQ29tbWVudDY0MDY1NjE0Mw== | 9599 | 2020-06-08T14:25:48Z | 2020-06-08T14:26:45Z | OWNER | Will we need a request correlation ID for this? Multiple asyncio threads can write things to the `ds._permission_checks` deque at the same time. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
634663505 |