github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/615#issuecomment-846668419 | https://api.github.com/repos/simonw/datasette/issues/615 | 846668419 | MDEyOklzc3VlQ29tbWVudDg0NjY2ODQxOQ== | 9599 | 2021-05-24T01:14:27Z | 2021-05-24T01:14:27Z | OWNER | I tried allowing the removal of `rowid` and got this exception: ``` File "/Users/simon/Dropbox/Development/datasette/datasette/views/table.py", line 831, in extra_template display_columns, display_rows = await self.display_columns_and_rows( File "/Users/simon/Dropbox/Development/datasette/datasette/views/table.py", line 163, in display_columns_and_rows pk_path = path_from_row_pks(row, pks, not pks, False) File "/Users/simon/Dropbox/Development/datasette/datasette/utils/__init__.py", line 82, in path_from_row_pks bits = [row["rowid"]] IndexError: No item with that key ``` I'm going to disable the removal of `rowid` - or indeed any of the primary keys, since they are needed to construct the row permalink. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
517451234 | |
https://github.com/simonw/datasette/issues/615#issuecomment-846660103 | https://api.github.com/repos/simonw/datasette/issues/615 | 846660103 | MDEyOklzc3VlQ29tbWVudDg0NjY2MDEwMw== | 9599 | 2021-05-24T00:47:00Z | 2021-05-24T00:47:00Z | OWNER | > Here's a bug: removing the `rowid` column returns an error. Removing the `rowid` column should work. We can continue to show the `Link` column, ensuring users can still navigate to the row page for each row. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
517451234 | |
https://github.com/simonw/datasette/issues/615#issuecomment-846659272 | https://api.github.com/repos/simonw/datasette/issues/615 | 846659272 | MDEyOklzc3VlQ29tbWVudDg0NjY1OTI3Mg== | 9599 | 2021-05-24T00:44:47Z | 2021-05-24T00:44:47Z | OWNER | I can't think of any good reasons to support passing the same column twice `?col=airline&_col=airline` so I'm going to de-duplicate and silently ignore the second one. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
517451234 |