github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/1296#issuecomment-850583584 | https://api.github.com/repos/simonw/datasette/issues/1296 | 850583584 | MDEyOklzc3VlQ29tbWVudDg1MDU4MzU4NA== | 9599 | 2021-05-28T18:06:11Z | 2021-05-28T18:06:11Z | OWNER | > As a bonus, the Docker image becomes smaller That's a huge surprise to me! And most welcome. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
855446829 | |
https://github.com/simonw/datasette/pull/1346#issuecomment-850059328 | https://api.github.com/repos/simonw/datasette/issues/1346 | 850059328 | MDEyOklzc3VlQ29tbWVudDg1MDA1OTMyOA== | 9599 | 2021-05-28T02:08:10Z | 2021-05-28T02:09:25Z | OWNER | This is the current test failure, but it actually another problem that we don't have tests in place for errors with different formats and shapes: ``` def test_magic_parameters_cannot_be_used_in_arbitrary_queries(magic_parameters_client): response = magic_parameters_client.get( "/data.json?sql=select+:_header_host&_shape=array" ) assert 400 == response.status > assert "You did not supply a value for binding 1." == response.json["error"] E TypeError: list indices must be integers or slices, not str ``` The test fails because `response.json` here is the empty list `[]`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
904537568 | |
https://github.com/simonw/datasette/issues/619#issuecomment-850059607 | https://api.github.com/repos/simonw/datasette/issues/619 | 850059607 | MDEyOklzc3VlQ29tbWVudDg1MDA1OTYwNw== | 9599 | 2021-05-28T02:08:58Z | 2021-05-28T02:08:58Z | OWNER | Remaining work will happen in #1346 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
520655983 | |
https://github.com/simonw/datasette/pull/1346#issuecomment-850058851 | https://api.github.com/repos/simonw/datasette/issues/1346 | 850058851 | MDEyOklzc3VlQ29tbWVudDg1MDA1ODg1MQ== | 9599 | 2021-05-28T02:06:46Z | 2021-05-28T02:06:46Z | OWNER | The one test failure here actually illustrates a larger problem: if the user specifies `.json?_shape=array` but an error occurs, what should we do? Prior to this change we return the following JSON: ```json { "ok": false, "error": "You did not supply a value for binding 1.", "status": 500, "title": null } ``` But this comes from the `handle_500` higher level code here: https://github.com/simonw/datasette/blob/eae3084b46e2c3931db12cdef79093ad0e644bce/datasette/app.py#L1251-L1263 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
904537568 | |
https://github.com/simonw/datasette/issues/619#issuecomment-850025106 | https://api.github.com/repos/simonw/datasette/issues/619 | 850025106 | MDEyOklzc3VlQ29tbWVudDg1MDAyNTEwNg== | 9599 | 2021-05-28T00:18:30Z | 2021-05-28T00:18:30Z | OWNER | I'm going to return a 400 HTTP status code for "bad request", under the assumption that the client sent bad SQL. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
520655983 | |
https://github.com/simonw/datasette/issues/619#issuecomment-850019486 | https://api.github.com/repos/simonw/datasette/issues/619 | 850019486 | MDEyOklzc3VlQ29tbWVudDg1MDAxOTQ4Ng== | 9599 | 2021-05-28T00:05:50Z | 2021-05-28T00:05:50Z | OWNER | Came up on discussions here: https://github.com/simonw/datasette/discussions/1334 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
520655983 |