github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/1495#issuecomment-950403692 | https://api.github.com/repos/simonw/datasette/issues/1495 | 950403692 | IC_kwDOBm6k_c44pgJs | 9599 | 2021-10-24T22:10:43Z | 2021-10-24T22:10:43Z | OWNER | To land this change we'll need a unit test that demonstrates the new capability - I suggest putting that next to this test: https://github.com/simonw/datasette/blob/15a9d4abfff0c45dee2a9f851326e1d61b1c678c/tests/test_plugins.py#L648-L659 It will also need documentation, which should be added here: https://github.com/simonw/datasette/blob/15a9d4abfff0c45dee2a9f851326e1d61b1c678c/docs/plugin_hooks.rst#register-routes-datasette | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1033678984 | |
https://github.com/simonw/datasette/pull/1495#issuecomment-950403521 | https://api.github.com/repos/simonw/datasette/issues/1495 | 950403521 | IC_kwDOBm6k_c44pgHB | 9599 | 2021-10-24T22:09:18Z | 2021-10-24T22:09:18Z | OWNER | This is a great idea - I've wanted this myself before, but never spent any time thinking about how to achieve it. I think your design here is exactly right - an optional third item in the tuple consisting of a dictionary of options to pass to the view function. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1033678984 |