github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/1559#issuecomment-997082676 | https://api.github.com/repos/simonw/datasette/issues/1559 | 997082676 | IC_kwDOBm6k_c47bkY0 | 9599 | 2021-12-17T23:09:41Z | 2021-12-17T23:09:41Z | OWNER | This is now available to try out in Datasette 0.60a0: https://github.com/simonw/datasette/releases/tag/0.60a0 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1082743068 | |
https://github.com/simonw/datasette/pull/1559#issuecomment-996961196 | https://api.github.com/repos/simonw/datasette/issues/1559 | 996961196 | IC_kwDOBm6k_c47bGus | 9599 | 2021-12-17T19:00:53Z | 2021-12-17T19:00:53Z | OWNER | I'm going to merge this to `main` now. I can continue the refactoring there, but having it in `main` means I can put out an alpha release with the new hook which will unblock me from running tests against it in this repo: https://github.com/simonw/datasette-leaflet-freedraw/pull/8 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1082743068 | |
https://github.com/simonw/datasette/pull/1559#issuecomment-996959325 | https://api.github.com/repos/simonw/datasette/issues/1559 | 996959325 | IC_kwDOBm6k_c47bGRd | 9599 | 2021-12-17T18:59:54Z | 2021-12-17T18:59:54Z | OWNER | I've convinced myself that this plugin hook design is good through this `datasette-leaflet-freedraw` prototype: https://github.com/simonw/datasette-leaflet-freedraw/blob/e8a16a0fe90656b8d655c02881d23a2b9833281d/datasette_leaflet_freedraw/__init__.py | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1082743068 | |
https://github.com/simonw/datasette/pull/1559#issuecomment-996895423 | https://api.github.com/repos/simonw/datasette/issues/1559 | 996895423 | IC_kwDOBm6k_c47a2q_ | 9599 | 2021-12-17T17:28:44Z | 2021-12-17T17:28:44Z | OWNER | Before I land this I'm going to build one prototype plugin against it to confirm that the new hook is useful in its current shape. I'll add support for filtering a table by drawing on a map to https://datasette.io/plugins/datasette-leaflet-freedraw | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1082743068 | |
https://github.com/simonw/datasette/pull/1559#issuecomment-996286808 | https://api.github.com/repos/simonw/datasette/issues/1559 | 996286808 | IC_kwDOBm6k_c47YiFY | 9599 | 2021-12-17T00:01:43Z | 2021-12-17T00:01:43Z | OWNER | This already has tests and documentation, and I've used it to refactor out the logic for `?_where=` and `?_search=` and `?_through=`. Do I like this enough to land it on `main`? Also, I think I can still use it to refactor out the `Filters` code that implements `?col=x` and `?col__lt=5` and suchlike. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1082743068 |