github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1527#issuecomment-1012653109 | https://api.github.com/repos/simonw/datasette/issues/1527 | 1012653109 | IC_kwDOBm6k_c48W9w1 | 9599 | 2022-01-14T00:57:08Z | 2022-01-14T00:57:08Z | OWNER | Bug is fixed on https://latest.datasette.io/fixtures/facetable?_sort=pk&_city_id__gt=1 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1059555791 | |
https://github.com/simonw/datasette/issues/1527#issuecomment-1012635696 | https://api.github.com/repos/simonw/datasette/issues/1527 | 1012635696 | IC_kwDOBm6k_c48W5gw | 9599 | 2022-01-14T00:19:10Z | 2022-01-14T00:20:36Z | OWNER | Oh! This is because `_city_id` has a leading underscore (for testing purposes). I think I need to filter out any keys that contain `__` in that case. What happens to columns that contain a `__`? They shouldn't be reflected in the hidden arguments either - this code is really only supposed to catch things like `_where` and `_m2m_through=` and `_col` - basically most of the list on https://docs.datasette.io/en/stable/json_api.html#special-table-arguments | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1059555791 | |
https://github.com/simonw/datasette/issues/1527#issuecomment-1012634659 | https://api.github.com/repos/simonw/datasette/issues/1527 | 1012634659 | IC_kwDOBm6k_c48W5Qj | 9599 | 2022-01-14T00:17:00Z | 2022-01-14T00:18:11Z | OWNER | That's because that page has this unnecessary hidden form field: ```html <input type="hidden" name="_city_id__gt" value="1"> ``` That field is added by this bit in the template: https://github.com/simonw/datasette/blob/515f8d38ebae203efc15ca79a8b42848276b35e5/datasette/templates/table.html#L119-L122 Which is populated here: https://github.com/simonw/datasette/blob/ace86566b28280091b3844cf5fbecd20158e9004/datasette/views/table.py#L813-L821 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1059555791 |