github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1802#issuecomment-1237533471 | https://api.github.com/repos/simonw/datasette/issues/1802 | 1237533471 | IC_kwDOBm6k_c5Jw0Mf | 9599 | 2022-09-05T23:59:26Z | 2022-09-05T23:59:26Z | OWNER | https://docs.python.org/3/library/asyncio-task.html#asyncio.run notes that `asyncio.run()` was added in Python 3.7. I dropped support for 3.6 a while ago. https://stackoverflow.com/a/56446830/6083 suggests that switching to `asyncio.run()` has helped other people dealing with the `RuntimeError: There is no current event loop in thread` error in the past. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362402998 | |
https://github.com/simonw/datasette/issues/1802#issuecomment-1237532571 | https://api.github.com/repos/simonw/datasette/issues/1802 | 1237532571 | IC_kwDOBm6k_c5Jwz-b | 9599 | 2022-09-05T23:56:28Z | 2022-09-05T23:56:28Z | OWNER | That didn't help. This time it was 3.9 that failed first: https://github.com/simonw/datasette/runs/8197403744?check_suite_focus=true - same error though. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362402998 | |
https://github.com/simonw/datasette/issues/1802#issuecomment-1237530726 | https://api.github.com/repos/simonw/datasette/issues/1802 | 1237530726 | IC_kwDOBm6k_c5Jwzhm | 9599 | 2022-09-05T23:50:18Z | 2022-09-05T23:50:18Z | OWNER | Tried again, this time it failed with 3.8: https://github.com/simonw/datasette/runs/8197344556?check_suite_focus=true I'm going to try ditching the parallel test execution. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362402998 | |
https://github.com/simonw/datasette/issues/1802#issuecomment-1237527575 | https://api.github.com/repos/simonw/datasette/issues/1802 | 1237527575 | IC_kwDOBm6k_c5JwywX | 9599 | 2022-09-05T23:40:32Z | 2022-09-05T23:40:32Z | OWNER | That passed too: ``` ========================================================= test session starts ========================================================== platform linux -- Python 3.7.13, pytest-7.1.3, pluggy-1.0.0 SQLite: 3.27.2 rootdir: /mnt, configfile: pytest.ini plugins: asyncio-0.19.0, anyio-3.6.1, timeout-2.1.0, xdist-2.5.0, forked-1.4.0 asyncio: mode=strict gw0 [1024] / gw1 [1024] / gw2 [1024] / gw3 [1024] / gw4 [1024] / gw5 [1024] ................................................................................................................................ [ 12%] ................................................................................................................................ [ 25%] ...............................................................................................................ss............... [ 37%] ................................................................................................................................ [ 50%] ................................................................................................................................ [ 62%] .................................................s..........................s................................................... [ 75%] ................................................................................................................................ [ 87%] ................................................................................................................................ [100%] ============================================= 1020 passed, 4 skipped in 294.43s (0:04:54) ============================================== ========================================================= test session starts ========================================================== platform linux -- Python 3.7.13, pytest-7.1.3, pluggy-1.0.0 SQLite: 3.27.2 rootdir: /mnt, configfile: pytest.ini plugins: asyncio-0.19.0, anyio-3.6.1, timeout-2.1.0, xdist-2.5.0, forked-1.4.0 asyncio: mode=strict … | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362402998 | |
https://github.com/simonw/datasette/issues/1802#issuecomment-1237523178 | https://api.github.com/repos/simonw/datasette/issues/1802 | 1237523178 | IC_kwDOBm6k_c5Jwxrq | 9599 | 2022-09-05T23:28:11Z | 2022-09-05T23:28:11Z | OWNER | Trying this instead: ``` docker run -it -v `pwd`:/mnt \ python:3.7-buster \ bash -c "cd /mnt && pip install -e '.[test]' && pytest -n auto -m 'not serial' && pytest -m 'serial'" ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362402998 | |
https://github.com/simonw/datasette/issues/1802#issuecomment-1237522793 | https://api.github.com/repos/simonw/datasette/issues/1802 | 1237522793 | IC_kwDOBm6k_c5Jwxlp | 9599 | 2022-09-05T23:27:08Z | 2022-09-05T23:27:08Z | OWNER | Here's how GitHub Actions runs them: https://github.com/simonw/datasette/blob/294ecd45f7801971dbeef383d0c5456ee95ab839/.github/workflows/test.yml#L27-L37 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362402998 | |
https://github.com/simonw/datasette/issues/1802#issuecomment-1237522547 | https://api.github.com/repos/simonw/datasette/issues/1802 | 1237522547 | IC_kwDOBm6k_c5Jwxhz | 9599 | 2022-09-05T23:26:19Z | 2022-09-05T23:26:19Z | OWNER | Annoyingly those tests pass just fine on my machine using that Docker recipe. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362402998 | |
https://github.com/simonw/datasette/issues/1802#issuecomment-1237522407 | https://api.github.com/repos/simonw/datasette/issues/1802 | 1237522407 | IC_kwDOBm6k_c5Jwxfn | 9599 | 2022-09-05T23:25:53Z | 2022-09-05T23:25:53Z | OWNER | Turned that into a TIL: https://til.simonwillison.net/docker/pytest-docker | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362402998 | |
https://github.com/simonw/datasette/issues/1802#issuecomment-1237519153 | https://api.github.com/repos/simonw/datasette/issues/1802 | 1237519153 | IC_kwDOBm6k_c5Jwwsx | 9599 | 2022-09-05T23:17:03Z | 2022-09-05T23:17:03Z | OWNER | Some previous issues where I've run Python in Docker: - https://github.com/simonw/datasette/issues/1344#issuecomment-849805778 - https://github.com/simonw/datasette/issues/1647#issuecomment-1059819628 For this one I'm going to try this image: `python:3.7-buster` - from https://hub.docker.com/layers/library/python/3.7-buster/images/sha256-8a79c5ddabd9e3bceb7d274e515d85a3f5898bd983bb5761ec94186bc54ae968?context=explore ``` docker run -it -v `pwd`:/mnt \ python:3.7-buster \ bash -c "cd /mnt && pip install -e '.[test]' && pytest" ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362402998 | |
https://github.com/simonw/datasette/issues/1802#issuecomment-1237405647 | https://api.github.com/repos/simonw/datasette/issues/1802 | 1237405647 | IC_kwDOBm6k_c5JwU_P | 9599 | 2022-09-05T19:21:41Z | 2022-09-05T19:21:41Z | OWNER | Step one: replicate this failure on my local machine. I'll probably use Docker for this. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362402998 | |
https://github.com/simonw/datasette/issues/1800#issuecomment-1237383202 | https://api.github.com/repos/simonw/datasette/issues/1800 | 1237383202 | IC_kwDOBm6k_c5JwPgi | 9599 | 2022-09-05T18:39:43Z | 2022-09-05T18:39:52Z | OWNER | Dependabot noticed: https://github.com/simonw/datasette/pull/1799#issuecomment-1237381569 > Looks like aiofiles is no longer updatable, so this is no longer needed. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362363685 | |
https://github.com/simonw/datasette/issues/1800#issuecomment-1237375000 | https://api.github.com/repos/simonw/datasette/issues/1800 | 1237375000 | IC_kwDOBm6k_c5JwNgY | 9599 | 2022-09-05T18:24:34Z | 2022-09-05T18:24:34Z | OWNER | I'm going to leave `black` pinned to the exact version simply because updates to Black can cause my tests to fail due to formatting style decisions they have made - and it's just a test dependency, not a install requires dependency. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362363685 | |
https://github.com/simonw/datasette/issues/1800#issuecomment-1237374713 | https://api.github.com/repos/simonw/datasette/issues/1800 | 1237374713 | IC_kwDOBm6k_c5JwNb5 | 9599 | 2022-09-05T18:24:00Z | 2022-09-05T18:24:00Z | OWNER | I'll do this in a PR to execute the tests before merging to main. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1362363685 | |
https://github.com/simonw/sqlite-utils/issues/482#issuecomment-1236511153 | https://api.github.com/repos/simonw/sqlite-utils/issues/482 | 1236511153 | IC_kwDOCGYnMM5Js6mx | 9599 | 2022-09-05T03:38:29Z | 2022-09-05T03:38:29Z | OWNER | This is an interesting research area! Running the same experiment as the one in https://www.cybertec-postgresql.com/en/column-order-in-postgresql-does-matter/ could demonstrate one way or another if column ordering makes a difference with regards to performance or not. My hunch is that even if it does this wouldn't be a feature to bake into `sqlite-utils` itself, beyond the existing features for changing the order of columns in a table (https://sqlite-utils.datasette.io/en/stable/python-api.html#changing-column-order). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1361355564 |