github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/185#issuecomment-412299013 | https://api.github.com/repos/simonw/datasette/issues/185 | 412299013 | MDEyOklzc3VlQ29tbWVudDQxMjI5OTAxMw== | 9599 | 2018-08-11T20:14:54Z | 2018-08-11T20:14:54Z | OWNER | I've been worrying about how this one relates to #260 - I'd like to validate metadata (to help protect against people e.g. misspelling `license_url` and then being confused when their license isn't displayed properly), but this issue requests the ability to add arbitrary additional keys to the metadata structure. I think the solution is to introduce a metadata key called `extra_metadata_keys` which allows you to specifically list the extra keys that you want to enable. Something like this: ``` { "title": "My title", "source": "Source", "source_url": "https://www.example.com/", "release_date": "2018-04-01", "extra_metadata_keys": ["release_date"] } ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
299760684 | |
https://github.com/simonw/datasette/issues/185#issuecomment-379595253 | https://api.github.com/repos/simonw/datasette/issues/185 | 379595253 | MDEyOklzc3VlQ29tbWVudDM3OTU5NTI1Mw== | 9599 | 2018-04-09T00:24:10Z | 2018-04-09T00:24:10Z | OWNER | @carlmjohnson in case you aren't following along with #189 I've shipped the first working prototype of sort-by-column - you can try it out here: https://datasette-issue-189-demo-2.now.sh/salaries-7859114-7859114/2017+Maryland+state+salaries?_search=university&_sort_desc=annual_salary | { "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
299760684 | |
https://github.com/simonw/datasette/issues/185#issuecomment-376604558 | https://api.github.com/repos/simonw/datasette/issues/185 | 376604558 | MDEyOklzc3VlQ29tbWVudDM3NjYwNDU1OA== | 9599 | 2018-03-27T17:16:27Z | 2018-03-27T17:16:27Z | OWNER | I am SO inspired by what you've done with https://salaries.news.baltimoresun.com/ - that's pretty much my ideal use-case for Datasette, and it's by far the most elaborate customization I've seen so far. I'd love to hear other ideas that came up while building that. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
299760684 | |
https://github.com/simonw/datasette/issues/185#issuecomment-376589591 | https://api.github.com/repos/simonw/datasette/issues/185 | 376589591 | MDEyOklzc3VlQ29tbWVudDM3NjU4OTU5MQ== | 9599 | 2018-03-27T16:30:51Z | 2018-03-27T16:30:51Z | OWNER | Also needed: the ability to unset metadata. If the root metadata specifies a license_url it should be possible to set "license_url": null on a child database or table. The current implementation will ignore null (or empty string) values and default to the top level value. I think the templates themselves should be able to indicate if they want the inherited values or not. That way we could support arbitrary key/values and avoid the application code having special knowledge of license_url etc. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
299760684 | |
https://github.com/simonw/datasette/issues/185#issuecomment-376587017 | https://api.github.com/repos/simonw/datasette/issues/185 | 376587017 | MDEyOklzc3VlQ29tbWVudDM3NjU4NzAxNw== | 9599 | 2018-03-27T16:22:59Z | 2018-03-27T16:22:59Z | OWNER | One thing that's missing from this: if you set source/license data at the individual database level they should be inherited by tables within that database. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
299760684 | |
https://github.com/simonw/datasette/issues/185#issuecomment-376585911 | https://api.github.com/repos/simonw/datasette/issues/185 | 376585911 | MDEyOklzc3VlQ29tbWVudDM3NjU4NTkxMQ== | 9599 | 2018-03-27T16:19:43Z | 2018-03-27T16:19:43Z | OWNER | OK, I have an implementation of this. I realised that not ALL metadata should be inherited: it makes sense for source/source_url/license/license_url to be inherited, but it doesn't make sense for the title and description to be inherited down to the individual databases and tables. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
299760684 | |
https://github.com/simonw/datasette/issues/185#issuecomment-370273359 | https://api.github.com/repos/simonw/datasette/issues/185 | 370273359 | MDEyOklzc3VlQ29tbWVudDM3MDI3MzM1OQ== | 9599 | 2018-03-04T23:10:56Z | 2018-03-04T23:10:56Z | OWNER | Are you talking specifically about accessing metadata from HTML templates? That makes a lot of sense, I'll think about how this could work. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
299760684 |