github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/800#issuecomment-640099404 | https://api.github.com/repos/simonw/datasette/issues/800 | 640099404 | MDEyOklzc3VlQ29tbWVudDY0MDA5OTQwNA== | 9599 | 2020-06-06T18:22:10Z | 2020-06-06T18:24:26Z | OWNER | Docs here: https://github.com/simonw/datasette/blob/d4c7b85f556230923d37ff327a068ed08aa9b62b/docs/authentication.rst#setting-permissions-for-canned-queries | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-640101625 | https://api.github.com/repos/simonw/datasette/issues/800 | 640101625 | MDEyOklzc3VlQ29tbWVudDY0MDEwMTYyNQ== | 9599 | 2020-06-06T18:40:09Z | 2020-06-06T18:40:09Z | OWNER | Documentation for `actor_matches_allow`: https://github.com/simonw/datasette/blob/14f6b4d200f24940a795ddc0825319ab2891bde2/docs/authentication.rst#actor_matches_allow | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-640123488 | https://api.github.com/repos/simonw/datasette/issues/800 | 640123488 | MDEyOklzc3VlQ29tbWVudDY0MDEyMzQ4OA== | 9599 | 2020-06-06T21:59:14Z | 2020-06-06T21:59:14Z | OWNER | I didn't build this quite right: it should be using the permissions plugin hook. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-640090343 | https://api.github.com/repos/simonw/datasette/issues/800 | 640090343 | MDEyOklzc3VlQ29tbWVudDY0MDA5MDM0Mw== | 9599 | 2020-06-06T17:04:36Z | 2020-06-06T17:04:36Z | OWNER | I like this mechanism better than the SQL query one. Constructing SQL queries that return true if a particular string is embedded inside a JSON list in a larger object is decidedly non-trivial. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-640099434 | https://api.github.com/repos/simonw/datasette/issues/800 | 640099434 | MDEyOklzc3VlQ29tbWVudDY0MDA5OTQzNA== | 9599 | 2020-06-06T18:22:29Z | 2020-06-06T18:22:29Z | OWNER | I should add the '*' bit to the docs. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-640103204 | https://api.github.com/repos/simonw/datasette/issues/800 | 640103204 | MDEyOklzc3VlQ29tbWVudDY0MDEwMzIwNA== | 9599 | 2020-06-06T18:52:56Z | 2020-06-06T18:52:56Z | OWNER | I'm also going to add an indicator to the UI next to queries that you can only execute because you are signed in: <img width="502" alt="data" src="https://user-images.githubusercontent.com/9599/83952232-403bc200-a7ec-11ea-94dc-f9b87ad3fb67.png"> | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-640090575 | https://api.github.com/repos/simonw/datasette/issues/800 | 640090575 | MDEyOklzc3VlQ29tbWVudDY0MDA5MDU3NQ== | 9599 | 2020-06-06T17:06:28Z | 2020-06-06T17:06:28Z | OWNER | I'm going to implement this documentation-first. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-640102200 | https://api.github.com/repos/simonw/datasette/issues/800 | 640102200 | MDEyOklzc3VlQ29tbWVudDY0MDEwMjIwMA== | 9599 | 2020-06-06T18:45:11Z | 2020-06-06T18:45:11Z | OWNER | In the code that's: https://github.com/simonw/datasette/blob/9c563d6aed072f14d3d25f58e84659f9caa1a243/datasette/views/database.py#L56-L64 And: https://github.com/simonw/datasette/blob/9c563d6aed072f14d3d25f58e84659f9caa1a243/datasette/views/database.py#L98-L112 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-639803719 | https://api.github.com/repos/simonw/datasette/issues/800 | 639803719 | MDEyOklzc3VlQ29tbWVudDYzOTgwMzcxOQ== | 9599 | 2020-06-05T20:40:34Z | 2020-06-05T20:40:34Z | OWNER | It's a bit obscure though. I'll try building both and see how they feel in practice. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-639803099 | https://api.github.com/repos/simonw/datasette/issues/800 | 639803099 | MDEyOklzc3VlQ29tbWVudDYzOTgwMzA5OQ== | 9599 | 2020-06-05T20:39:34Z | 2020-06-05T20:39:34Z | OWNER | Maybe #801 (configuring permissions with a SQL query) is enough here - might not need this mechanism at all, since that mechanism covers it. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-640099707 | https://api.github.com/repos/simonw/datasette/issues/800 | 640099707 | MDEyOklzc3VlQ29tbWVudDY0MDA5OTcwNw== | 9599 | 2020-06-06T18:24:54Z | 2020-06-06T18:24:54Z | OWNER | Next step: a utility function and tests for matching actors to allow blocks. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-640101762 | https://api.github.com/repos/simonw/datasette/issues/800 | 640101762 | MDEyOklzc3VlQ29tbWVudDY0MDEwMTc2Mg== | 9599 | 2020-06-06T18:41:20Z | 2020-06-06T18:41:20Z | OWNER | Now the actual permission checks. I need these in two places: the code that generates the list of available queries on https://latest.datasette.io/fixtures#queries and the query page itself at https://latest.datasette.io/fixtures/pragma_cache_size | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-640160487 | https://api.github.com/repos/simonw/datasette/issues/800 | 640160487 | MDEyOklzc3VlQ29tbWVudDY0MDE2MDQ4Nw== | 9599 | 2020-06-07T05:34:07Z | 2020-06-07T05:34:07Z | OWNER | See #810 for work to finish this. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 | |
https://github.com/simonw/datasette/issues/800#issuecomment-640108835 | https://api.github.com/repos/simonw/datasette/issues/800 | 640108835 | MDEyOklzc3VlQ29tbWVudDY0MDEwODgzNQ== | 9599 | 2020-06-06T19:42:46Z | 2020-06-06T19:42:46Z | OWNER | This is implemented and documented: https://datasette.readthedocs.io/en/latest/authentication.html | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
631931408 |