github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1088#issuecomment-725830716 | https://api.github.com/repos/simonw/datasette/issues/1088 | 725830716 | MDEyOklzc3VlQ29tbWVudDcyNTgzMDcxNg== | 9599 | 2020-11-12T04:35:38Z | 2020-11-12T04:35:38Z | OWNER | I'm going to fix this without a test, because writing a test for this is a bit fiddly and it's a very minor bug. If it comes back again I'll do the work to test for it. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
741268956 | |
https://github.com/simonw/datasette/issues/1088#issuecomment-725830533 | https://api.github.com/repos/simonw/datasette/issues/1088 | 725830533 | MDEyOklzc3VlQ29tbWVudDcyNTgzMDUzMw== | 9599 | 2020-11-12T04:35:08Z | 2020-11-12T04:35:08Z | OWNER | Yup, swapping `QueryInterrupted` fixed this against my giant database. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
741268956 | |
https://github.com/simonw/datasette/issues/1088#issuecomment-725829903 | https://api.github.com/repos/simonw/datasette/issues/1088 | 725829903 | MDEyOklzc3VlQ29tbWVudDcyNTgyOTkwMw== | 9599 | 2020-11-12T04:33:14Z | 2020-11-12T04:33:14Z | OWNER | I'm suspicious of this code: https://github.com/simonw/datasette/blob/e8e0a6f284ca953b2980186c4356594c07bd1929/datasette/views/table.py#L1032-L1045 This code uses a different exception: https://github.com/simonw/datasette/blob/e8e0a6f284ca953b2980186c4356594c07bd1929/datasette/views/table.py#L658-L663 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
741268956 |