github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1091#issuecomment-758283074 | https://api.github.com/repos/simonw/datasette/issues/1091 | 758283074 | MDEyOklzc3VlQ29tbWVudDc1ODI4MzA3NA== | 9599 | 2021-01-11T23:12:46Z | 2021-01-11T23:12:46Z | OWNER | Fantastic! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-756453945 | https://api.github.com/repos/simonw/datasette/issues/1091 | 756453945 | MDEyOklzc3VlQ29tbWVudDc1NjQ1Mzk0NQ== | 9599 | 2021-01-07T23:42:50Z | 2021-01-07T23:42:50Z | OWNER | @henry501 it looks like you spotted a bug in the documentation - I just addressed that, the fix is now live here: https://docs.datasette.io/en/latest/deploying.html#running-datasette-behind-a-proxy | { "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-756453010 | https://api.github.com/repos/simonw/datasette/issues/1091 | 756453010 | MDEyOklzc3VlQ29tbWVudDc1NjQ1MzAxMA== | 9599 | 2021-01-07T23:39:58Z | 2021-01-07T23:40:25Z | OWNER | @tballison I think that's the solution! It looks like you need to use this in your config: `ProxyPass /datasette http://127.0.0.1:8001/datasette` Instead of this: `ProxyPass /datasette http://127.0.0.1:8001/` Give that a go and let me know if it fixes it. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-741992106 | https://api.github.com/repos/simonw/datasette/issues/1091 | 741992106 | MDEyOklzc3VlQ29tbWVudDc0MTk5MjEwNg== | 9599 | 2020-12-09T19:19:54Z | 2020-12-09T20:27:45Z | OWNER | Could you try removing the `ProxyPassReverse /datasette http://0.0.0.0:8001` line? My hunch is that `ProxyPassReverse` is rewriting some of the links in the HTML (or maybe in the HTTP headers) in a way that breaks things. Normally you would need `ProxyPassReverse` to compensate for the underlying application being unable to rewrite its links - but Datasette's `base_url` setting causes Datasette to rewrite all of the links for you, so `ProxyPassReverse` should be unneccessary. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-742023541 | https://api.github.com/repos/simonw/datasette/issues/1091 | 742023541 | MDEyOklzc3VlQ29tbWVudDc0MjAyMzU0MQ== | 9599 | 2020-12-09T20:17:54Z | 2020-12-09T20:17:54Z | OWNER | OK that is really weird. I'll have another go at replicating this locally. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-728262974 | https://api.github.com/repos/simonw/datasette/issues/1091 | 728262974 | MDEyOklzc3VlQ29tbWVudDcyODI2Mjk3NA== | 9599 | 2020-11-16T19:05:08Z | 2020-11-16T19:05:08Z | OWNER | I have a hunch that there may be some extra configuration in play here - could Apache itself be rewriting some of the links using [mod_proxy_html](https://httpd.apache.org/docs/2.4/mod/mod_proxy_html.html)? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-727233553 | https://api.github.com/repos/simonw/datasette/issues/1091 | 727233553 | MDEyOklzc3VlQ29tbWVudDcyNzIzMzU1Mw== | 9599 | 2020-11-14T16:46:52Z | 2020-11-14T16:46:52Z | OWNER | @tballison could I see the section of your Apache config that configures the proxying to `/datasette/`? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-726416330 | https://api.github.com/repos/simonw/datasette/issues/1091 | 726416330 | MDEyOklzc3VlQ29tbWVudDcyNjQxNjMzMA== | 9599 | 2020-11-13T00:00:43Z | 2020-11-13T00:00:43Z | OWNER | Here's where `url_csv` comes from: https://github.com/simonw/datasette/blob/11eb1e026f3d84cb771f8d6e204939cbaee130cd/datasette/views/base.py#L542-L545 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-726415991 | https://api.github.com/repos/simonw/datasette/issues/1091 | 726415991 | MDEyOklzc3VlQ29tbWVudDcyNjQxNTk5MQ== | 9599 | 2020-11-12T23:59:34Z | 2020-11-12T23:59:34Z | OWNER | The sort headers are generated by this template code: https://github.com/simonw/datasette/blob/5eb8e9bf250b26e30b017d39a392c33973997656/datasette/templates/_table.html#L11-L15 The export links use this code: https://github.com/simonw/datasette/blob/5eb8e9bf250b26e30b017d39a392c33973997656/datasette/templates/table.html#L134 https://github.com/simonw/datasette/blob/5eb8e9bf250b26e30b017d39a392c33973997656/datasette/templates/table.html#L180-L201 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-726415019 | https://api.github.com/repos/simonw/datasette/issues/1091 | 726415019 | MDEyOklzc3VlQ29tbWVudDcyNjQxNTAxOQ== | 9599 | 2020-11-12T23:56:23Z | 2020-11-12T23:56:23Z | OWNER | @tballison is there any chance you're running any custom templates in that installation? I'm really confused as to why I can't replicate the bug. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-726413829 | https://api.github.com/repos/simonw/datasette/issues/1091 | 726413829 | MDEyOklzc3VlQ29tbWVudDcyNjQxMzgyOQ== | 9599 | 2020-11-12T23:52:50Z | 2020-11-12T23:54:16Z | OWNER | Hmm... it's not just the `.csv` and `.json` export links - it's the column headings (which can be clicked to change the sort order) as well. Here's an extract of the HTML from that page: ```html <p class="export-links">This data as <a href="/corpora-metadata/REF_PARSE_EXCEPTION_TYPES.json">json</a>, <a href="/corpora-metadata/REF_PARSE_EXCEPTION_TYPES.csv?_size=max">CSV</a> ( <a href="#export">advanced</a>) </p> <div class="table-wrapper"> <table class="rows-and-columns"> <thead> <tr> <th class="col-Link" scope="col" data-column="Link" data-column-type="" data-column-not-null="0" data-is-pk="0"> Link </th> <th class="col-rowid" scope="col" data-column="rowid" data-column-type="integer" data-column-not-null="0" data-is-pk="1"> <a href="/corpora-metadata/REF_PARSE_EXCEPTION_TYPES?_sort_desc=rowid" rel="nofollow">rowid ▼</a> </th> <th class="col-PARSE_EXCEPTION_ID" scope="col" data-column="PARSE_EXCEPTION_ID" data-column-type="INTEGER" data-column-not-null="0" data-is-pk="0"> <a href="/corpora-metadata/REF_PARSE_EXCEPTION_TYPES?_sort=PARSE_EXCEPTION_ID" rel="nofollow">PARSE_EXCEPTION_ID</a> </th> <th class="col-PARSE_EXCEPTION_DESCRIPTION" scope="col" data-column="PARSE_EXCEPTION_DESCRIPTION" data-column-type="VARCHAR(128)" data-column-not-null="0" data-is-pk="0"> <a href="/corpora-metadata/REF_PARSE_EXCEPTION_TYPES?_sort=PARSE_EXCEPTION_DESCRIPTION" rel="nofollow">PARSE_EXCEPTION_DESCRIPTION</a> </th> </tr> </thead> <tbody> <tr> <td class="col-Link type-pk"> <a href="/datasette/corpora-metadata/REF_PARSE_EXCEPTION_TYPES/1">1</a> </td> <td class="col-rowid type-int">1</td> <td class="col-PARSE_EXCEPTION_ID type-int">0</td> <td class="col-PARSE_EXCEPTION_DESCRIPTION type-str">RUNTIME</td> </tr> <tr> <td class="col-Link type-pk"> <a href="/datasette/corpora-… | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 |