github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1041#issuecomment-719986800 | https://api.github.com/repos/simonw/datasette/issues/1041 | 719986800 | MDEyOklzc3VlQ29tbWVudDcxOTk4NjgwMA== | 9599 | 2020-10-31T20:49:28Z | 2020-10-31T20:49:28Z | OWNER | Implemented in a4ca26a2659d21779adf625183061d8879954c15 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
727627923 | |
https://github.com/simonw/datasette/issues/1041#issuecomment-714683801 | https://api.github.com/repos/simonw/datasette/issues/1041 | 714683801 | MDEyOklzc3VlQ29tbWVudDcxNDY4MzgwMQ== | 9599 | 2020-10-22T18:37:47Z | 2020-10-22T18:37:47Z | OWNER | I think I'll do this by looking for URLs that start with `/` - since it's also possible to have full `https://...` URLs in that setting. ```json { "extra_css_urls": [ "/static/styles.css" ], "extra_js_urls": [ "/static/app.js" ] } ``` I need to think about the `extra_css_urls` and `extra_js_urls` plugin hooks too: https://docs.datasette.io/en/stable/plugin_hooks.html#extra-css-urls-template-database-table-columns-view-name-request-datasette | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
727627923 | |
https://github.com/simonw/datasette/issues/1041#issuecomment-714682825 | https://api.github.com/repos/simonw/datasette/issues/1041 | 714682825 | MDEyOklzc3VlQ29tbWVudDcxNDY4MjgyNQ== | 9599 | 2020-10-22T18:36:10Z | 2020-10-22T18:36:10Z | OWNER | I'll need to update these docs once there's a solution for this in place: https://docs.datasette.io/en/latest/custom_templates.html#serving-static-files | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
727627923 | |
https://github.com/simonw/datasette/issues/1041#issuecomment-714682288 | https://api.github.com/repos/simonw/datasette/issues/1041 | 714682288 | MDEyOklzc3VlQ29tbWVudDcxNDY4MjI4OA== | 9599 | 2020-10-22T18:35:15Z | 2020-10-22T18:35:15Z | OWNER | @psychemedia said: https://github.com/simonw/datasette/issues/1033#issuecomment-714657366 > How does `/-/static` relate to [current guidance docs around `static`](https://docs.datasette.io/en/latest/custom_templates.html?highlight=static#serving-static-files) regarding the `--static option` and metadata formulations such as `"extra_js_urls": [ "/static/app.js"]` (I've not managed to get this to work in a Jupyter server proxied set up; the [datasette / jupyter server proxy repo](https://github.com/simonw/jupyterserverproxy-datasette-demo) may provide a useful test example, eg via MyBinder, for folk to crib from?) | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
727627923 |