github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1545#issuecomment-1028535868 | https://api.github.com/repos/simonw/datasette/issues/1545 | 1028535868 | IC_kwDOBm6k_c49TjY8 | 9599 | 2022-02-03T02:08:30Z | 2022-02-03T02:08:30Z | OWNER | Filed an issue with Jinja suggesting a documentation update: - https://github.com/pallets/jinja/issues/1578 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1075893249 | |
https://github.com/simonw/datasette/issues/1545#issuecomment-1028517268 | https://api.github.com/repos/simonw/datasette/issues/1545 | 1028517268 | IC_kwDOBm6k_c49Te2U | 9599 | 2022-02-03T01:26:53Z | 2022-02-03T01:26:53Z | OWNER | I understand the problem now! https://github.com/pallets/jinja/issues/1378#issuecomment-812410922 > Jinja template names/paths are not always filesystem paths. So regardless of the OS Jinja always uses forward slashes. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1075893249 | |
https://github.com/simonw/datasette/issues/1545#issuecomment-997462604 | https://api.github.com/repos/simonw/datasette/issues/1545 | 997462604 | IC_kwDOBm6k_c47dBJM | 9599 | 2021-12-19T21:17:08Z | 2021-12-19T21:17:08Z | OWNER | Here's the relevant code: https://github.com/simonw/datasette/blob/4094741c2881c2ada3f3f878b532fdaec7914953/datasette/app.py#L1204-L1219 It's using `route_path.split("/")` which should be OK because that's the incoming `request.path` path - which I would expect to use `/` even on Windows. Then it uses `os.path.join` which should do the right thing. I need to get myself a proper Windows development environment setup to investigate this one. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1075893249 |