github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1469#issuecomment-917839062 | https://api.github.com/repos/simonw/datasette/issues/1469 | 917839062 | IC_kwDOBm6k_c42tRzW | 9599 | 2021-09-13T04:52:01Z | 2021-09-13T04:52:01Z | OWNER | Here's the code at fault: https://github.com/simonw/datasette/blob/b28b6cd2fe97f7e193a235877abeec2c8eb0a821/datasette/static/table.js#L137-L146 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
994450961 | |
https://github.com/simonw/datasette/issues/1469#issuecomment-942725632 | https://api.github.com/repos/simonw/datasette/issues/1469 | 942725632 | IC_kwDOBm6k_c44MNoA | 9599 | 2021-10-13T21:13:30Z | 2021-10-13T21:13:30Z | OWNER | The core problem here is treating the `?_facet=` query string parameters as the point of truth for which facets are currently enabled. Instead, I could use a `data-` attribute on the displayed facets. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
994450961 |