issue_comments
13 rows where "updated_at" is on date 2023-06-29 and user = 9599 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: reactions
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
1613887492 | https://github.com/simonw/datasette/issues/2093#issuecomment-1613887492 | https://api.github.com/repos/simonw/datasette/issues/2093 | IC_kwDOBm6k_c5gMfgE | simonw 9599 | 2023-06-29T22:40:25Z | 2023-06-29T22:40:25Z | OWNER | I'm strongly in favour of combining settings, configuration and plugin configuration. I'm not keen on mixing in metadata as well - that feels like a different concept to me, and I'm unhappy with how that's already had things like plugin settings leak into it. I'm not yet sold on TOML - I actually find it less intuitive than YAML, surprisingly. They all have their warts I guess. Datasette already has the ability to consume JSON or YAML for metadata - maybe it could grow TOML support too? That way users could have a In terms of metadata: since that's means to be driven by a plugin hook anyway, maybe one of the potential sources of metadata is a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Proposal: Combine settings, metadata, static, etc. into a single `datasette.yaml` File 1781530343 | |
1613381990 | https://github.com/simonw/datasette/issues/2092#issuecomment-1613381990 | https://api.github.com/repos/simonw/datasette/issues/2092 | IC_kwDOBm6k_c5gKkFm | simonw 9599 | 2023-06-29T15:23:04Z | 2023-06-29T15:26:28Z | OWNER | Felt lazy:
File: tests/test_api.py Line: 26@pytest.mark.asyncio async def test_homepage(ds_client): response = await ds_client.get("/.json") assert response.status_code == 200 assert "application/json; charset=utf-8" == response.headers["content-type"] data = response.json() assert isinstance(data.keys(), int) d = data["fixtures"] assert d["name"] == "fixtures" assert isinstance(d["tables_count"], int) assert isinstance(len(d["tables_and_views_truncated"]), int) assert d["tables_and_views_more"] is True # 4 hidden FTS tables + no_primary_key (hidden in metadata) assert isinstance(d["hidden_tables_count"], int) # 201 in no_primary_key, plus 6 in other hidden tables: assert isinstance(d["hidden_table_rows_sum"], int), data assert isinstance(d["views_count"], int) ``` I'll use most of that and delete the obsoleted comments. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
test_homepage intermittent failure 1781047747 | |
1613375407 | https://github.com/simonw/datasette/issues/2092#issuecomment-1613375407 | https://api.github.com/repos/simonw/datasette/issues/2092 | IC_kwDOBm6k_c5gKiev | simonw 9599 | 2023-06-29T15:20:52Z | 2023-06-29T15:21:05Z | OWNER | I'm going to remove this assertion entirely. The homepage JSON needs a refactor anyway. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
test_homepage intermittent failure 1781047747 | |
1613369355 | https://github.com/simonw/datasette/issues/2091#issuecomment-1613369355 | https://api.github.com/repos/simonw/datasette/issues/2091 | IC_kwDOBm6k_c5gKhAL | simonw 9599 | 2023-06-29T15:18:34Z | 2023-06-29T15:18:34Z | OWNER | Posted on the Glitch feedback forum about this here: https://support.glitch.com/t/upgrade-python-version-from-3-7-which-is-now-eol-to-something-more-recent/63011 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Drop support for Python 3.7 1781022369 | |
1613360413 | https://github.com/simonw/datasette/issues/2091#issuecomment-1613360413 | https://api.github.com/repos/simonw/datasette/issues/2091 | IC_kwDOBm6k_c5gKe0d | simonw 9599 | 2023-06-29T15:13:04Z | 2023-06-29T15:13:04Z | OWNER | One problem: https://glitch.com/ still provides 3.7:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Drop support for Python 3.7 1781022369 | |
1613346412 | https://github.com/simonw/datasette/issues/2090#issuecomment-1613346412 | https://api.github.com/repos/simonw/datasette/issues/2090 | IC_kwDOBm6k_c5gKbZs | simonw 9599 | 2023-06-29T15:05:04Z | 2023-06-29T15:05:04Z | OWNER | Decided to fix just those "Ambiguous variable name" ones:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Adopt ruff for linting 1781005740 | |
1613339404 | https://github.com/simonw/datasette/issues/2090#issuecomment-1613339404 | https://api.github.com/repos/simonw/datasette/issues/2090 | IC_kwDOBm6k_c5gKZsM | simonw 9599 | 2023-06-29T15:01:01Z | 2023-06-29T15:01:20Z | OWNER | I tried it just now and got some interesting results. I dropped in a Then run:
Some lines in tests are longer than even 160 chars, e.g.: These can have That got it down to:
I could fix that by getting rid of |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Adopt ruff for linting 1781005740 | |
1613316722 | https://github.com/simonw/datasette/issues/2089#issuecomment-1613316722 | https://api.github.com/repos/simonw/datasette/issues/2089 | IC_kwDOBm6k_c5gKUJy | simonw 9599 | 2023-06-29T14:48:10Z | 2023-06-29T14:48:10Z | OWNER | Spell check is passing now. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
codespell test failure 1780973290 | |
1613315851 | https://github.com/simonw/datasette/issues/2089#issuecomment-1613315851 | https://api.github.com/repos/simonw/datasette/issues/2089 | IC_kwDOBm6k_c5gKT8L | simonw 9599 | 2023-06-29T14:47:38Z | 2023-06-29T14:47:38Z | OWNER | Confirmed, this was a 2.2.5 change: https://github.com/codespell-project/codespell/releases/tag/v2.2.5
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
codespell test failure 1780973290 | |
1613307716 | https://github.com/simonw/datasette/issues/2089#issuecomment-1613307716 | https://api.github.com/repos/simonw/datasette/issues/2089 | IC_kwDOBm6k_c5gKR9E | simonw 9599 | 2023-06-29T14:42:23Z | 2023-06-29T14:42:23Z | OWNER | Yes, upgrading locally got me the correct version and the test failure:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
codespell test failure 1780973290 | |
1613306787 | https://github.com/simonw/datasette/issues/2089#issuecomment-1613306787 | https://api.github.com/repos/simonw/datasette/issues/2089 | IC_kwDOBm6k_c5gKRuj | simonw 9599 | 2023-06-29T14:41:47Z | 2023-06-29T14:41:47Z | OWNER | Looks like in CI it's running 2.2.5:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
codespell test failure 1780973290 | |
1613305070 | https://github.com/simonw/datasette/issues/2089#issuecomment-1613305070 | https://api.github.com/repos/simonw/datasette/issues/2089 | IC_kwDOBm6k_c5gKRTu | simonw 9599 | 2023-06-29T14:40:44Z | 2023-06-29T14:40:44Z | OWNER | I'm not sure why I can't duplicate this failure in my local development environment:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
codespell test failure 1780973290 | |
1613290899 | https://github.com/simonw/datasette/pull/2077#issuecomment-1613290899 | https://api.github.com/repos/simonw/datasette/issues/2077 | IC_kwDOBm6k_c5gKN2T | simonw 9599 | 2023-06-29T14:32:16Z | 2023-06-29T14:32:16Z | OWNER | @dependabot recreate |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Bump furo from 2023.3.27 to 2023.5.20 1719759468 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue 6