issue_comments

Table actions

5 rows where author_association = "NONE" and issue = 299760684 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Metadata should be a nested arbitrary KV store · 5 ✖

author_association 1

  • NONE · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
412663658 https://github.com/simonw/datasette/issues/185#issuecomment-412663658 https://api.github.com/repos/simonw/datasette/issues/185 MDEyOklzc3VlQ29tbWVudDQxMjY2MzY1OA== carlmjohnson 222245 2018-08-13T21:04:11Z 2018-08-13T21:04:11Z NONE

That seems good to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Metadata should be a nested arbitrary KV store 299760684  
376614973 https://github.com/simonw/datasette/issues/185#issuecomment-376614973 https://api.github.com/repos/simonw/datasette/issues/185 MDEyOklzc3VlQ29tbWVudDM3NjYxNDk3Mw== carlmjohnson 222245 2018-03-27T17:49:00Z 2018-03-27T17:49:00Z NONE

@simonw Other than metadata, the biggest item on wishlist for the salaries project was the ability to reorder by column. Of course, that could be done with a custom SQL query, but we didn't want to have to reimplement all the nav/pagination stuff from scratch.

@carolinp, feel free to add your thoughts.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Metadata should be a nested arbitrary KV store 299760684  
376592044 https://github.com/simonw/datasette/issues/185#issuecomment-376592044 https://api.github.com/repos/simonw/datasette/issues/185 MDEyOklzc3VlQ29tbWVudDM3NjU5MjA0NA== carlmjohnson 222245 2018-03-27T16:38:23Z 2018-03-27T16:38:23Z NONE

It would be nice to also allow arbitrary keys (maybe under a parent key called params or something to prevent conflicts). For our datasette project, we just have a bunch of dictionaries defined in the base template for things like site URL and column humanized names: https://github.com/baltimore-sun-data/salaries-datasette/blob/master/templates/base.html It would be cleaner if this were in the metadata.json.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Metadata should be a nested arbitrary KV store 299760684  
376590265 https://github.com/simonw/datasette/issues/185#issuecomment-376590265 https://api.github.com/repos/simonw/datasette/issues/185 MDEyOklzc3VlQ29tbWVudDM3NjU5MDI2NQ== carlmjohnson 222245 2018-03-27T16:32:51Z 2018-03-27T16:32:51Z NONE

I think the templates themselves should be able to indicate if they want the inherited values or not. That way we could support arbitrary key/values and avoid the application code having special knowledge of license_url etc.

Yes, you could have metadata that works like metadata does currently and inherited_metadata that works with inheritance.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Metadata should be a nested arbitrary KV store 299760684  
370461231 https://github.com/simonw/datasette/issues/185#issuecomment-370461231 https://api.github.com/repos/simonw/datasette/issues/185 MDEyOklzc3VlQ29tbWVudDM3MDQ2MTIzMQ== carlmjohnson 222245 2018-03-05T15:43:56Z 2018-03-05T15:44:27Z NONE

Yes. I think the simplest implementation is to change lines like

python metadata = self.ds.metadata.get('databases', {}).get(name, {})

to

python metadata = { **self.ds.metadata, **self.ds.metadata.get('databases', {}).get(name, {}), }

so that specified inner values overwrite outer values, but only if they exist.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Metadata should be a nested arbitrary KV store 299760684  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);