issue_comments

Table actions

2 rows where author_association = "OWNER" and issue = 1339663518 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Include "entrypoint" option on `--load-extension`? · 2 ✖

author_association 1

  • OWNER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1216042605 https://github.com/simonw/datasette/issues/1784#issuecomment-1216042605 https://api.github.com/repos/simonw/datasette/issues/1784 IC_kwDOBm6k_c5Ie1Zt simonw 9599 2022-08-16T01:28:46Z 2022-08-16T01:28:46Z OWNER

Do you want to write a PR for this?

Ideally I'd want this to be covered by a test, but it looks like --load-extension isn't covered by tests at all yet. It's a tricky thing to add to the unit tests because there are plenty of Python installs out there (including the one on my Mac) that don't support .enable_load_extension() at all.

So maybe a test which uses @pytest.mark.skipIf() to skip itself if the environment it is running in doesn't support that feature?

But we'd also need to bundle a compiled SQLite extension to use in the test, which would be a slightly weird thing to have in the repo.

We do have one previous example of something like that though: https://github.com/simonw/datasette/blob/main/tests/spatialite.db and the script that builds it https://github.com/simonw/datasette/blob/main/tests/build_small_spatialite_db.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Include "entrypoint" option on `--load-extension`? 1339663518  
1216035677 https://github.com/simonw/datasette/issues/1784#issuecomment-1216035677 https://api.github.com/repos/simonw/datasette/issues/1784 IC_kwDOBm6k_c5Ieztd simonw 9599 2022-08-16T01:13:18Z 2022-08-16T01:13:32Z OWNER

I didn't know SQLite could do this.

I agree with you - I like the : option you described there.

I'd like to stick with --load-extension - --load is general enough that I might have it do something else in the future, and this is a rare enough advanced feature that I'm OK with it being verbose.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Include "entrypoint" option on `--load-extension`? 1339663518  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);