issue_comments

Table actions

3 rows where author_association = "OWNER" and issue = 1400374908 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • docker image is duplicating db files somehow · 3 ✖

author_association 1

  • OWNER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1272344884 https://github.com/simonw/datasette/issues/1836#issuecomment-1272344884 https://api.github.com/repos/simonw/datasette/issues/1836 IC_kwDOBm6k_c5L1nE0 simonw 9599 2022-10-08T15:41:28Z 2022-10-08T15:41:28Z OWNER

Lets switch to mode=ro when the inspect command runs, we can use this issue for that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 docker image is duplicating db files somehow 1400374908  
1271006020 https://github.com/simonw/datasette/issues/1836#issuecomment-1271006020 https://api.github.com/repos/simonw/datasette/issues/1836 IC_kwDOBm6k_c5LwgNE simonw 9599 2022-10-07T01:54:07Z 2022-10-07T01:54:07Z OWNER

Just overlapped with your comment here: https://github.com/simonw/datasette/issues/1836#issuecomment-1271003212 - which notes that opening with ?immutable=1 DOES seem to cause the file to be duplicated!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 docker image is duplicating db files somehow 1400374908  
1271004167 https://github.com/simonw/datasette/issues/1836#issuecomment-1271004167 https://api.github.com/repos/simonw/datasette/issues/1836 IC_kwDOBm6k_c5LwfwH simonw 9599 2022-10-07T01:53:05Z 2022-10-07T01:53:05Z OWNER

Oh this is interesting!

Is your hunch here that running this line is causing the file to be stored as a second layer?

https://github.com/simonw/datasette/blob/5aa359b86907d11b3ee601510775a85a90224da8/datasette/utils/init.py#L399

I guess it's possible that running a non-read-only query against the database causes one or two bytes to be changed (maybe a transaction ID or similar?)

Modifying the inspect command to use ?mode=ro seems sensible to me. Except.... it should already be opening those files in immutable mode according to this line: https://github.com/simonw/datasette/blob/eff112498ecc499323c26612d707908831446d25/datasette/cli.py#L172-L173

Here's what opening as a immutables does:

https://github.com/simonw/datasette/blob/eff112498ecc499323c26612d707908831446d25/datasette/app.py#L258-L260

https://github.com/simonw/datasette/blob/eff112498ecc499323c26612d707908831446d25/datasette/database.py#L98

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 docker image is duplicating db files somehow 1400374908  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);