home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

3 rows where author_association = "OWNER", issue = 309047460 and user = 9599 sorted by updated_at descending

✖
✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 3 ✖

issue 1

  • Ability to bundle metadata and templates inside the SQLite file · 3 ✖

author_association 1

  • OWNER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
738905376 https://github.com/simonw/datasette/issues/188#issuecomment-738905376 https://api.github.com/repos/simonw/datasette/issues/188 MDEyOklzc3VlQ29tbWVudDczODkwNTM3Ng== simonw 9599 2020-12-04T17:18:34Z 2020-12-04T17:18:34Z OWNER

This is likely to be covered by plugin hooks: #860 for the metadata and after investigating in #1042 it looks like the existing prepare_jinja2_environment hook may already be enough to load templates from the database.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to bundle metadata and templates inside the SQLite file 309047460  
412291327 https://github.com/simonw/datasette/issues/188#issuecomment-412291327 https://api.github.com/repos/simonw/datasette/issues/188 MDEyOklzc3VlQ29tbWVudDQxMjI5MTMyNw== simonw 9599 2018-08-11T17:53:17Z 2018-08-11T17:53:17Z OWNER

Potential problem: the existing metadata.json format looks like this:

{ "title": "Custom title for your index page", "description": "Some description text can go here", "license": "ODbL", "license_url": "https://opendatacommons.org/licenses/odbl/", "databases": { "database1": { "source": "Alternative source", "source_url": "http://example.com/", "tables": { "example_table": { "description_html": "Custom <em>table</em> description", "license": "CC BY 3.0 US", "license_url": "https://creativecommons.org/licenses/by/3.0/us/" } } } } }

This doesn't make sense for metadata that is bundled with a specific database - there's no point in having the databases key, instead the content of database1 in the above example should be at the top level. This also means that if you rename the *.db file you won't have to edit its metadata at the same time.

Calling such an embedded file metadata.json when the shape is different could be confusing. Maybe call it database-metadata.json instead.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to bundle metadata and templates inside the SQLite file 309047460  
376594727 https://github.com/simonw/datasette/issues/188#issuecomment-376594727 https://api.github.com/repos/simonw/datasette/issues/188 MDEyOklzc3VlQ29tbWVudDM3NjU5NDcyNw== simonw 9599 2018-03-27T16:46:49Z 2018-05-28T21:34:34Z OWNER

One point of complexity: datasette can be used to bundle multiple .db files into a single "app".

I think that's OK. We could require that the datasette_files table is present in the first database file passed on the command-line. Or we could even construct a search path and consult multiple versions of the table spread across multiple files.

That said... any configuration that corresponds to a specific table should live in the same database file as that table.

Ditto for general metadata: if we have license/source information for a specific table or database that information should be able to live in the same .db file as the data.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to bundle metadata and templates inside the SQLite file 309047460  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 427.044ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows