issue_comments

Table actions

4 rows where author_association = "OWNER" and issue = 338768551 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Datasette on Zeit Now returns http URLs for facet and next links · 4 ✖

author_association 1

  • OWNER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
407267966 https://github.com/simonw/datasette/issues/333#issuecomment-407267966 https://api.github.com/repos/simonw/datasette/issues/333 MDEyOklzc3VlQ29tbWVudDQwNzI2Nzk2Ng== simonw 9599 2018-07-24T03:21:42Z 2018-07-24T03:21:42Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Datasette on Zeit Now returns http URLs for facet and next links 338768551  
407109113 https://github.com/simonw/datasette/issues/333#issuecomment-407109113 https://api.github.com/repos/simonw/datasette/issues/333 MDEyOklzc3VlQ29tbWVudDQwNzEwOTExMw== simonw 9599 2018-07-23T15:59:02Z 2018-07-23T15:59:02Z OWNER

I still need to modify datasette publish now to set this config option on the instances that it deploys.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Datasette on Zeit Now returns http URLs for facet and next links 338768551  
405988035 https://github.com/simonw/datasette/issues/333#issuecomment-405988035 https://api.github.com/repos/simonw/datasette/issues/333 MDEyOklzc3VlQ29tbWVudDQwNTk4ODAzNQ== simonw 9599 2018-07-18T16:12:35Z 2018-07-18T16:12:35Z OWNER

I'll add a absolute_url(request, path) method on the base view class which knows to check the new config option.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Datasette on Zeit Now returns http URLs for facet and next links 338768551  
405975025 https://github.com/simonw/datasette/issues/333#issuecomment-405975025 https://api.github.com/repos/simonw/datasette/issues/333 MDEyOklzc3VlQ29tbWVudDQwNTk3NTAyNQ== simonw 9599 2018-07-18T15:36:11Z 2018-07-18T15:40:04Z OWNER

A force_https_api_urls config option would work here - if set, Datasette will ignore the incoming protocol and always use https. The datasette deploy now command could then add that as an option passed to datasette serve.

This is the pattern which is producing incorrect URLs on Zeit Now, because the Sanic request.url property is not being correctly set.

https://github.com/simonw/datasette/blob/6e37f091edec35e2706197489f54fff5d890c63c/datasette/views/table.py#L653-L655

Suggested help text:

Always use https:// for URLs output as part of Datasette API responses

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Datasette on Zeit Now returns http URLs for facet and next links 338768551  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);