issue_comments

Table actions

6 rows where author_association = "OWNER", issue = 637342551 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 6 ✖

issue 1

  • startup() plugin hook · 6 ✖

author_association 1

  • OWNER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
650811919 https://github.com/simonw/datasette/issues/834#issuecomment-650811919 https://api.github.com/repos/simonw/datasette/issues/834 MDEyOklzc3VlQ29tbWVudDY1MDgxMTkxOQ== simonw 9599 2020-06-28T19:38:50Z 2020-06-28T19:38:50Z OWNER

I have two plugins in progress that use this hook now:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 startup() plugin hook 637342551  
643657067 https://github.com/simonw/datasette/issues/834#issuecomment-643657067 https://api.github.com/repos/simonw/datasette/issues/834 MDEyOklzc3VlQ29tbWVudDY0MzY1NzA2Nw== simonw 9599 2020-06-13T17:59:42Z 2020-06-28T04:01:52Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 startup() plugin hook 637342551  
643648359 https://github.com/simonw/datasette/issues/834#issuecomment-643648359 https://api.github.com/repos/simonw/datasette/issues/834 MDEyOklzc3VlQ29tbWVudDY0MzY0ODM1OQ== simonw 9599 2020-06-13T16:47:29Z 2020-06-13T16:47:29Z OWNER

Implementing this is proving surprisingly tricky, because of the need to be able to optionally await the returned value. It's a bit of a fiddle to get this to work within unit tests because they run in non-async functions - due to this cunning async_to_sync usage in the test client:

https://github.com/simonw/datasette/blob/b906030235efbdff536405d66078f4868ce0d3bd/tests/fixtures.py#L115-L133

I could switch to using async def test_* functions decorated with @pytest.mark.asyncio but I'd rather not re-engineer the entire test suite just for this one feature, so I'll try to find another way.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 startup() plugin hook 637342551  
643510240 https://github.com/simonw/datasette/issues/834#issuecomment-643510240 https://api.github.com/repos/simonw/datasette/issues/834 MDEyOklzc3VlQ29tbWVudDY0MzUxMDI0MA== simonw 9599 2020-06-12T22:40:26Z 2020-06-12T22:40:26Z OWNER

Another use-case: plugins that need their own database with the correct tables. They can write to the database on startup to create their tables.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 startup() plugin hook 637342551  
643509358 https://github.com/simonw/datasette/issues/834#issuecomment-643509358 https://api.github.com/repos/simonw/datasette/issues/834 MDEyOklzc3VlQ29tbWVudDY0MzUwOTM1OA== simonw 9599 2020-06-12T22:36:37Z 2020-06-12T22:36:37Z OWNER

This should be able to optionally return an async function which is then awaited.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 startup() plugin hook 637342551  
643501064 https://github.com/simonw/datasette/issues/834#issuecomment-643501064 https://api.github.com/repos/simonw/datasette/issues/834 MDEyOklzc3VlQ29tbWVudDY0MzUwMTA2NA== simonw 9599 2020-06-12T22:04:43Z 2020-06-12T22:04:43Z OWNER

Another use-case for this: I want to use the --root option on Glitch but it gives me a 127.0.0.1 URL. Glitch has a PROJECT_DOMAIN environment variable which tells me the URL. A datasette-glitch plugin could use a startup hook to output the correct login URL.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 startup() plugin hook 637342551  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);