issue_comments
17 rows where author_association = "OWNER", "updated_at" is on date 2020-04-05 and user = 9599 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: issue_url, reactions, updated_at (date)
user 1
- simonw · 17 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
609461331 | https://github.com/simonw/datasette/issues/716#issuecomment-609461331 | https://api.github.com/repos/simonw/datasette/issues/716 | MDEyOklzc3VlQ29tbWVudDYwOTQ2MTMzMQ== | simonw 9599 | 2020-04-05T18:31:32Z | 2020-04-05T20:04:08Z | OWNER | The test ended up being a bit fiddly - here it is: I used In writing this I realized that the So I removed the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
extra_template_vars() sending wrong view_name for index 594168758 | |
609456030 | https://github.com/simonw/datasette/issues/716#issuecomment-609456030 | https://api.github.com/repos/simonw/datasette/issues/716 | MDEyOklzc3VlQ29tbWVudDYwOTQ1NjAzMA== | simonw 9599 | 2020-04-05T17:52:39Z | 2020-04-05T20:02:13Z | OWNER | Found it. Prior to that change I passed I switched over to doing this: But forgot to pass in the optional Next step: write a failing test, then fix it. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
extra_template_vars() sending wrong view_name for index 594168758 | |
609469440 | https://github.com/simonw/datasette/issues/689#issuecomment-609469440 | https://api.github.com/repos/simonw/datasette/issues/689 | MDEyOklzc3VlQ29tbWVudDYwOTQ2OTQ0MA== | simonw 9599 | 2020-04-05T19:28:59Z | 2020-04-05T19:28:59Z | OWNER | So I think the fix is to move the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"Templates considered" comment broken in >=0.35 573583971 | |
609469318 | https://github.com/simonw/datasette/issues/689#issuecomment-609469318 | https://api.github.com/repos/simonw/datasette/issues/689 | MDEyOklzc3VlQ29tbWVudDYwOTQ2OTMxOA== | simonw 9599 | 2020-04-05T19:28:14Z | 2020-04-05T19:28:14Z | OWNER | Here's why: the Which means this logic is always called with a template, not a list of strings: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"Templates considered" comment broken in >=0.35 573583971 | |
609468485 | https://github.com/simonw/datasette/issues/689#issuecomment-609468485 | https://api.github.com/repos/simonw/datasette/issues/689 | MDEyOklzc3VlQ29tbWVudDYwOTQ2ODQ4NQ== | simonw 9599 | 2020-04-05T19:22:31Z | 2020-04-05T19:22:31Z | OWNER | ``` $ git bisect start master 0.34 Bisecting: 32 revisions left to test after this (roughly 5 steps) [dc80e779a2e708b2685fc641df99e6aae9ad6f97] Handle scope path if it is a string $ git bisect run python check_templates_considered.py running python check_templates_considered.py Traceback (most recent call last): ... AssertionError Bisecting: 15 revisions left to test after this (roughly 4 steps) [7c6a9c35299f251f9abfb03fd8e85143e4361709] Better tests for prepare_connection() plugin hook, refs #678 running python check_templates_considered.py Traceback (most recent call last): ... AssertionError Bisecting: 7 revisions left to test after this (roughly 3 steps) [0091dfe3e5a3db94af8881038d3f1b8312bb857d] More reliable tie-break ordering for facet results running python check_templates_considered.py Traceback (most recent call last): ... AssertionError Bisecting: 3 revisions left to test after this (roughly 2 steps) [ce12244037b60ba0202c814871218c1dab38d729] Release notes for 0.35 running python check_templates_considered.py Traceback (most recent call last): ... AssertionError Bisecting: 1 revision left to test after this (roughly 1 step) [70b915fb4bc214f9d064179f87671f8a378aa127] Datasette.render_template() method, closes #577 running python check_templates_considered.py Traceback (most recent call last): ... AssertionError Bisecting: 0 revisions left to test after this (roughly 0 steps) [286ed286b68793532c2a38436a08343b45cfbc91] geojson-to-sqlite running python check_templates_considered.py 70b915fb4bc214f9d064179f87671f8a378aa127 is the first bad commit commit 70b915fb4bc214f9d064179f87671f8a378aa127 Author: Simon Willison swillison@gmail.com Date: Tue Feb 4 12:26:17 2020 -0800
:040000 040000 def9e31252e056845609de36c66d4320dd0c47f8 da19b7f8c26d50a4c05e5a7f05220b968429725c M datasette bisect run success ``` It was 70b915fb4bc214f9d064179f87671f8a378aa127 - the same bad commit that caused #716! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"Templates considered" comment broken in >=0.35 573583971 | |
609468180 | https://github.com/simonw/datasette/issues/689#issuecomment-609468180 | https://api.github.com/repos/simonw/datasette/issues/689 | MDEyOklzc3VlQ29tbWVudDYwOTQ2ODE4MA== | simonw 9599 | 2020-04-05T19:20:33Z | 2020-04-05T19:20:33Z | OWNER |
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"Templates considered" comment broken in >=0.35 573583971 | |
609467876 | https://github.com/simonw/datasette/issues/689#issuecomment-609467876 | https://api.github.com/repos/simonw/datasette/issues/689 | MDEyOklzc3VlQ29tbWVudDYwOTQ2Nzg3Ng== | simonw 9599 | 2020-04-05T19:18:36Z | 2020-04-05T19:18:36Z | OWNER | Just need the one checking script to run with bisect this time: ```python import asyncio import pathlib from datasette.app import Datasette import httpx async def run_check(): ds = Datasette([]) async with httpx.AsyncClient(app=ds.app()) as client: response = await client.get("http://localhost/") assert 200 == response.status_code assert "Templates considered" in response.text if name == "main": loop = asyncio.get_event_loop() loop.run_until_complete(run_check()) ``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"Templates considered" comment broken in >=0.35 573583971 | |
609467523 | https://github.com/simonw/datasette/issues/689#issuecomment-609467523 | https://api.github.com/repos/simonw/datasette/issues/689 | MDEyOklzc3VlQ29tbWVudDYwOTQ2NzUyMw== | simonw 9599 | 2020-04-05T19:16:13Z | 2020-04-05T19:16:13Z | OWNER | I'm going to debug this using |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"Templates considered" comment broken in >=0.35 573583971 | |
609466998 | https://github.com/simonw/datasette/issues/693#issuecomment-609466998 | https://api.github.com/repos/simonw/datasette/issues/693 | MDEyOklzc3VlQ29tbWVudDYwOTQ2Njk5OA== | simonw 9599 | 2020-04-05T19:12:48Z | 2020-04-05T19:12:48Z | OWNER | Fixed. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Variables from extra_template_vars() not exposed in _context=1 574043218 | |
609461623 | https://github.com/simonw/datasette/issues/693#issuecomment-609461623 | https://api.github.com/repos/simonw/datasette/issues/693 | MDEyOklzc3VlQ29tbWVudDYwOTQ2MTYyMw== | simonw 9599 | 2020-04-05T18:33:46Z | 2020-04-05T18:33:46Z | OWNER | So I should move the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Variables from extra_template_vars() not exposed in _context=1 574043218 | |
609455243 | https://github.com/simonw/datasette/issues/716#issuecomment-609455243 | https://api.github.com/repos/simonw/datasette/issues/716 | MDEyOklzc3VlQ29tbWVudDYwOTQ1NTI0Mw== | simonw 9599 | 2020-04-05T17:47:33Z | 2020-04-05T17:47:33Z | OWNER | You start
:040000 040000 def9e31252e056845609de36c66d4320dd0c47f8 da19b7f8c26d50a4c05e5a7f05220b968429725c M datasette bisect run success ``` So 70b915fb4bc214f9d064179f87671f8a378aa127 introduced the bug! |
{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 } |
extra_template_vars() sending wrong view_name for index 594168758 | |
609453886 | https://github.com/simonw/datasette/issues/716#issuecomment-609453886 | https://api.github.com/repos/simonw/datasette/issues/716 | MDEyOklzc3VlQ29tbWVudDYwOTQ1Mzg4Ng== | simonw 9599 | 2020-04-05T17:38:38Z | 2020-04-05T17:42:14Z | OWNER | OK, here's the test harness. Three files:
root = pathlib.Path(file).parent async def run_check(): ds = Datasette( [], template_dir=str(root / "templates"), plugins_dir=str(root / "plugins") ) async with httpx.AsyncClient(app=ds.app()) as client: response = await client.get("http://localhost/") assert 200 == response.status_code assert b"view_name:index" == response.content, response.content if name == "main": loop = asyncio.get_event_loop() loop.run_until_complete(run_check()) ```
@hookimpl def extra_template_vars(view_name): return {"view_name": view_name} ``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
extra_template_vars() sending wrong view_name for index 594168758 | |
609454072 | https://github.com/simonw/datasette/issues/716#issuecomment-609454072 | https://api.github.com/repos/simonw/datasette/issues/716 | MDEyOklzc3VlQ29tbWVudDYwOTQ1NDA3Mg== | simonw 9599 | 2020-04-05T17:39:47Z | 2020-04-05T17:39:47Z | OWNER |
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
extra_template_vars() sending wrong view_name for index 594168758 | |
609306846 | https://github.com/simonw/datasette/issues/717#issuecomment-609306846 | https://api.github.com/repos/simonw/datasette/issues/717 | MDEyOklzc3VlQ29tbWVudDYwOTMwNjg0Ng== | simonw 9599 | 2020-04-05T04:18:48Z | 2020-04-05T04:18:48Z | OWNER | I need to route all paths to the same function. This should help: https://twitter.com/aboodman/status/1246605658067066882 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
See if I can get Datasette working on Zeit Now v2 594189527 | |
609111516 | https://github.com/simonw/datasette/issues/717#issuecomment-609111516 | https://api.github.com/repos/simonw/datasette/issues/717 | MDEyOklzc3VlQ29tbWVudDYwOTExMTUxNg== | simonw 9599 | 2020-04-05T00:57:29Z | 2020-04-05T00:57:29Z | OWNER | If I can get this working I think I'll release it as a plugin, similar to datasette-publish-fly. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
See if I can get Datasette working on Zeit Now v2 594189527 | |
609109354 | https://github.com/simonw/datasette/issues/716#issuecomment-609109354 | https://api.github.com/repos/simonw/datasette/issues/716 | MDEyOklzc3VlQ29tbWVudDYwOTEwOTM1NA== | simonw 9599 | 2020-04-05T00:30:30Z | 2020-04-05T00:31:55Z | OWNER | In order to use I'm going to use something I can execute with |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
extra_template_vars() sending wrong view_name for index 594168758 | |
609107679 | https://github.com/simonw/datasette/issues/716#issuecomment-609107679 | https://api.github.com/repos/simonw/datasette/issues/716 | MDEyOklzc3VlQ29tbWVudDYwOTEwNzY3OQ== | simonw 9599 | 2020-04-05T00:10:37Z | 2020-04-05T00:11:06Z | OWNER | Once I fix this bug I should update https://github.com/simonw/museums to deploy using the latest Datasette release as opposed to being anchored to 286ed28. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
extra_template_vars() sending wrong view_name for index 594168758 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue 4