issue_comments

Table actions

8 rows where "created_at" is on date 2020-10-21 and issue = 725996507 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Make it possible to download BLOB data from the Datasette UI · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
713899530 https://github.com/simonw/datasette/issues/1036#issuecomment-713899530 https://api.github.com/repos/simonw/datasette/issues/1036 MDEyOklzc3VlQ29tbWVudDcxMzg5OTUzMA== simonw 9599 2020-10-21T21:55:00Z 2020-10-21T21:55:00Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it possible to download BLOB data from the Datasette UI 725996507  
713821656 https://github.com/simonw/datasette/issues/1036#issuecomment-713821656 https://api.github.com/repos/simonw/datasette/issues/1036 MDEyOklzc3VlQ29tbWVudDcxMzgyMTY1Ng== simonw 9599 2020-10-21T19:22:45Z 2020-10-21T19:41:48Z OWNER

So for https://latest.datasette.io/fixtures/binary_data the BLOB download URLs would be:

https://latest.datasette.io/fixtures/-/blob/binary_data/1/data.blob - that last bit after the primary key is to indicate the data column

With these headers:

  • Content-Disposition: attachment; filename="binary_data-1-data.blob"
  • X-Content-Type-Options: nosniff
  • Content-Type: application/binary
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it possible to download BLOB data from the Datasette UI 725996507  
713830842 https://github.com/simonw/datasette/issues/1036#issuecomment-713830842 https://api.github.com/repos/simonw/datasette/issues/1036 MDEyOklzc3VlQ29tbWVudDcxMzgzMDg0Mg== simonw 9599 2020-10-21T19:41:20Z 2020-10-21T19:41:20Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it possible to download BLOB data from the Datasette UI 725996507  
713829629 https://github.com/simonw/datasette/issues/1036#issuecomment-713829629 https://api.github.com/repos/simonw/datasette/issues/1036 MDEyOklzc3VlQ29tbWVudDcxMzgyOTYyOQ== simonw 9599 2020-10-21T19:38:43Z 2020-10-21T19:38:43Z OWNER

Should this work just for BLOB columns, or should it work for other columns too?

For the moment I'm going to restrict it to BLOBs, since data from other columns is available through the UI whereas BLOB columns are not.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it possible to download BLOB data from the Datasette UI 725996507  
713818817 https://github.com/simonw/datasette/issues/1036#issuecomment-713818817 https://api.github.com/repos/simonw/datasette/issues/1036 MDEyOklzc3VlQ29tbWVudDcxMzgxODgxNw== simonw 9599 2020-10-21T19:17:01Z 2020-10-21T19:17:01Z OWNER

Actually I like .blob

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it possible to download BLOB data from the Datasette UI 725996507  
713818178 https://github.com/simonw/datasette/issues/1036#issuecomment-713818178 https://api.github.com/repos/simonw/datasette/issues/1036 MDEyOklzc3VlQ29tbWVudDcxMzgxODE3OA== simonw 9599 2020-10-21T19:15:38Z 2020-10-21T19:16:34Z OWNER

What should the suggested filename be?

I think something that includes the table name, primary key and the name of the column would work.

How about a file extension? I guess .binary, then let the user rename it? Or .raw.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it possible to download BLOB data from the Datasette UI 725996507  
713278349 https://github.com/simonw/datasette/issues/1036#issuecomment-713278349 https://api.github.com/repos/simonw/datasette/issues/1036 MDEyOklzc3VlQ29tbWVudDcxMzI3ODM0OQ== simonw 9599 2020-10-21T03:42:29Z 2020-10-21T03:42:29Z OWNER

Possible URL for this: /db/table/-/blob/primary-keys - this would use the /db/table/-/ namespace proposed in #296.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it possible to download BLOB data from the Datasette UI 725996507  
713226726 https://github.com/simonw/datasette/issues/1036#issuecomment-713226726 https://api.github.com/repos/simonw/datasette/issues/1036 MDEyOklzc3VlQ29tbWVudDcxMzIyNjcyNg== simonw 9599 2020-10-21T01:04:25Z 2020-10-21T01:04:25Z OWNER

Extra security idea: a blob_download_host setting which can be used to indicate a host that should be used for downloads - for example datasettestatic.com. If this setting is populated then binary downloads are served from paths on that host only, and no other Datasette URLs from that host will be served.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Make it possible to download BLOB data from the Datasette UI 725996507  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);