issue_comments

Table actions

1 row where issue = 1337541526 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • `facet_time_limit_ms` and `sql_time_limit_ms` overlap? · 1 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1215992640 https://github.com/simonw/datasette/issues/1780#issuecomment-1215992640 https://api.github.com/repos/simonw/datasette/issues/1780 IC_kwDOBm6k_c5IepNA simonw 9599 2022-08-15T23:50:02Z 2022-08-15T23:50:02Z OWNER

This is deliberate, but maybe it's a bad design decision?

Right now Datasette assumes you made a mistake if you set facet_time_limit_ms higher than sql_time_limit_ms and ignores you.

Maybe it would be better if it refused to start the server at all and showed you an error message?

``` % datasette . --setting facet_time_limit_ms 30000 Error: facet_time_limit_ms greater than sql_time_limit_ms. Try this instead:

datasette . --setting facet_time_limit_ms 30000 --setting sql_time_limit_ms 30000

```

Or perhaps running this should set both of the time limits to 30s:

datasette . --setting facet_time_limit_ms 30000

I'm nervous about doing that though as it feels like it may surprise people who only wanted to increase one of the limits.

Option 3: make it so it's possible for facets to have a greater time limit than SQL queries generally.

Maybe that's the best option? It's not surprising to people, and I think it's reasonable to implement.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `facet_time_limit_ms` and `sql_time_limit_ms` overlap? 1337541526  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);