issue_comments

Would love to put our heads together for improvements here.

I think anything that is argname=DEFAULT needs to be typed as argname: str | Default = DEFAULT (replacing str with the appropriate type(s)). We may be able to get clever and tie the types to that key in the _defaults dict (definitely possible in Typescript, but I'm less familiar with advanced python types).

Right now, all args are typed as Default, which means all callers get type errors.

As for table/view, given that they don't have the same methods, it would be nice to be able to get one or the other specifically.

With respect to the typing of Table class itself, my interim solution:

python from sqlite_utils.db import Table def tbl(self, table_name: str) -> Table: tbl = self.db[table_name] if isinstance(tbl, Table): return tbl raise Exception(f"Missing {table_name=}")

With respect to @chapmanjacobd concern on the DEFAULT being an empty class, have also been using # type: ignore, e.g.

python @classmethod def insert_list(cls, areas: list[str]): return meta.tbl(meta.Areas).insert_all( ({"area": a} for a in areas), ignore=True # type: ignore )

I was going to suggest using db.table(name) instead of db[name] - but it looks like that method will have the same problem:

https://github.com/simonw/sqlite-utils/blob/defa2974c6d3abc19be28d6b319649b8028dc966/sqlite_utils/db.py#L497-L506

I could change sqlite-utils so db.table(name) always returns a table and you need to call db.view(name) if you want to access a view - that would require bumping to 4.0 though. I'm not convinced that's the best approach here either.

I do care about this, but I'm not hugely experienced with types yet so I'm open to suggestions about how to do it!