issue_comments

Table actions

5 rows where issue = 1473411197 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 5 ✖

issue 1

  • ignore:true/replace:true options for /db/-/create API · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1339910494 https://github.com/simonw/datasette/issues/1927#issuecomment-1339910494 https://api.github.com/repos/simonw/datasette/issues/1927 IC_kwDOBm6k_c5P3Wle simonw 9599 2022-12-06T19:37:39Z 2022-12-06T19:37:39Z OWNER

I'll finish this after I land: - #1931 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ignore:true/replace:true options for /db/-/create API 1473411197  
1336099588 https://github.com/simonw/datasette/issues/1927#issuecomment-1336099588 https://api.github.com/repos/simonw/datasette/issues/1927 IC_kwDOBm6k_c5Po0ME simonw 9599 2022-12-03T06:58:14Z 2022-12-03T06:58:14Z OWNER

I have not yet documented the new insert and replace options.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ignore:true/replace:true options for /db/-/create API 1473411197  
1336099533 https://github.com/simonw/datasette/issues/1927#issuecomment-1336099533 https://api.github.com/repos/simonw/datasette/issues/1927 IC_kwDOBm6k_c5Po0LN simonw 9599 2022-12-03T06:57:52Z 2022-12-03T06:57:52Z OWNER

I'm going to push what I have anyway. I'll keep this issue open while I think through the above comment.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ignore:true/replace:true options for /db/-/create API 1473411197  
1336099368 https://github.com/simonw/datasette/issues/1927#issuecomment-1336099368 https://api.github.com/repos/simonw/datasette/issues/1927 IC_kwDOBm6k_c5Po0Io simonw 9599 2022-12-03T06:56:36Z 2022-12-03T06:56:36Z OWNER

Neither of these options make sense if you didn't pass a "pk".

My initial implementation spotted if the pk was missing and looked it up from the table, but actually I don't think that makes sense - if you know the table exists and hence don't pass the pk you should be using /-/insert or /-/upsert instead.

So maybe this work should expanded to include validation that checks if the table exists already - and if it does, confirms that the primary key (and maybe even the columns) are the same as for that existing table.

Of course if you only send row or rows then checking columns doesn't completely make sense - but we could check that the rows you have sent are equal to or a subset of the columns in the table. We could even check the column types as well, as seen in: - #1910 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ignore:true/replace:true options for /db/-/create API 1473411197  
1335984268 https://github.com/simonw/datasette/issues/1927#issuecomment-1335984268 https://api.github.com/repos/simonw/datasette/issues/1927 IC_kwDOBm6k_c5PoYCM simonw 9599 2022-12-03T00:26:26Z 2022-12-03T00:26:26Z OWNER

Also: the documentation should clarify that you can call this API multiple times when using the rows option.

(It will probably grow "alter": true soon too).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ignore:true/replace:true options for /db/-/create API 1473411197  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);