issue_comments

Table actions

3 rows where issue = 276704327 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • _group_count= feature improvements · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
392568047 https://github.com/simonw/datasette/issues/150#issuecomment-392568047 https://api.github.com/repos/simonw/datasette/issues/150 MDEyOklzc3VlQ29tbWVudDM5MjU2ODA0Nw== simonw 9599 2018-05-28T16:41:28Z 2018-05-28T16:41:28Z OWNER

Closing this as obsolete since we have facets now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 _group_count= feature improvements 276704327  
379559319 https://github.com/simonw/datasette/issues/150#issuecomment-379559319 https://api.github.com/repos/simonw/datasette/issues/150 MDEyOklzc3VlQ29tbWVudDM3OTU1OTMxOQ== simonw 9599 2018-04-08T15:35:43Z 2018-04-08T15:35:43Z OWNER

From a code point of view, the current mechanism for _group_count makes the TableView even more complicated:

https://github.com/simonw/datasette/blob/446d47fdb005b3776bc06ad8d1f44b01fc2e938b/datasette/app.py#L644-L653

Instead, I think if _group_count is detected we should generate the SQL and then defer to self.custom_sql, like we do for canned queries:

https://github.com/simonw/datasette/blob/446d47fdb005b3776bc06ad8d1f44b01fc2e938b/datasette/app.py#L539-L541

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 _group_count= feature improvements 276704327  
379559214 https://github.com/simonw/datasette/issues/150#issuecomment-379559214 https://api.github.com/repos/simonw/datasette/issues/150 MDEyOklzc3VlQ29tbWVudDM3OTU1OTIxNA== simonw 9599 2018-04-08T15:33:58Z 2018-04-08T15:33:58Z OWNER

The single biggest challenge here is expanding foreign key references. This is the blocker that prevents _group_count from being useful at the moment.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 _group_count= feature improvements 276704327  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);