home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

5 rows where issue = 322591993 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw 5

issue 1

  • Refactor views · 5 ✖

author_association 1

  • OWNER 5
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
388628966 https://github.com/simonw/datasette/pull/257#issuecomment-388628966 https://api.github.com/repos/simonw/datasette/issues/257 MDEyOklzc3VlQ29tbWVudDM4ODYyODk2Ng== simonw 9599 2018-05-13T14:00:47Z 2018-05-13T14:06:35Z OWNER

Running specific tests: venv35/bin/pip install pytest beautifulsoup4 aiohttp venv35/bin/pytest tests/test_utils.py

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Refactor views 322591993  
388627281 https://github.com/simonw/datasette/pull/257#issuecomment-388627281 https://api.github.com/repos/simonw/datasette/issues/257 MDEyOklzc3VlQ29tbWVudDM4ODYyNzI4MQ== simonw 9599 2018-05-13T13:36:21Z 2018-05-13T13:36:21Z OWNER

https://github.com/rtfd/readthedocs.org/issues/3812#issuecomment-373780860 suggests Python 3.5.2 may have the fix.

Yup, that worked:

``` pyenv install 3.5.2 rm -rf venv35 /Users/simonw/.pyenv/versions/3.5.2/bin/python -mvenv venv35 source venv35/bin/activate

Not sure why I need this in my local environment but I do:

pip install datasette_plugin_demos python setup.py test ```

This is now giving me the same test failure locally that I am seeing in Travis.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Refactor views 322591993  
388626804 https://github.com/simonw/datasette/pull/257#issuecomment-388626804 https://api.github.com/repos/simonw/datasette/issues/257 MDEyOklzc3VlQ29tbWVudDM4ODYyNjgwNA== simonw 9599 2018-05-13T13:28:20Z 2018-05-13T13:28:20Z OWNER

Unfortunately, running python setup.py test on my laptop using Python 3.5.0 in that virtualenv results in a flow of weird Sanic-related errors:

File "/Users/simonw/Dropbox/Development/datasette/venv35/lib/python3.5/site-packages/sanic-0.7.0-py3.5.egg/sanic/testing.py", line 16, in _local_request import aiohttp File "/Users/simonw/Dropbox/Development/datasette/.eggs/aiohttp-2.3.2-py3.5-macosx-10.13-x86_64.egg/aiohttp/__init__.py", line 6, in <module> from .client import * # noqa File "/Users/simonw/Dropbox/Development/datasette/.eggs/aiohttp-2.3.2-py3.5-macosx-10.13-x86_64.egg/aiohttp/client.py", line 13, in <module> from yarl import URL File "/Users/simonw/Dropbox/Development/datasette/.eggs/yarl-1.2.4-py3.5-macosx-10.13-x86_64.egg/yarl/__init__.py", line 11, in <module> from .quoting import _Quoter, _Unquoter File "/Users/simonw/Dropbox/Development/datasette/.eggs/yarl-1.2.4-py3.5-macosx-10.13-x86_64.egg/yarl/quoting.py", line 3, in <module> from typing import Optional, TYPE_CHECKING, cast ImportError: cannot import name 'TYPE_CHECKING'

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Refactor views 322591993  
388626721 https://github.com/simonw/datasette/pull/257#issuecomment-388626721 https://api.github.com/repos/simonw/datasette/issues/257 MDEyOklzc3VlQ29tbWVudDM4ODYyNjcyMQ== simonw 9599 2018-05-13T13:27:04Z 2018-05-13T13:27:04Z OWNER

I managed to get Python 3.5.0 running on my laptop using pyenv. Here's the incantation I used:

```

Install pyenv using homebrew (turns out I already had it)

brew install pyenv

Check which versions of Python I have installed

pyenv versions

Install Python 3.5.0

pyenv install 3.5.0

Figure out where pyenv has been installing things

pyenv root

Check I can run my newly installed Python 3.5.0

/Users/simonw/.pyenv/versions/3.5.0/bin/python

Use it to create a new virtualenv

/Users/simonw/.pyenv/versions/3.5.0/bin/python -mvenv venv35 source venv35/bin/activate

Install datasette into that virtualenv

python setup.py install ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Refactor views 322591993  
388625703 https://github.com/simonw/datasette/pull/257#issuecomment-388625703 https://api.github.com/repos/simonw/datasette/issues/257 MDEyOklzc3VlQ29tbWVudDM4ODYyNTcwMw== simonw 9599 2018-05-13T13:10:09Z 2018-05-13T13:10:09Z OWNER

I'm still seeing intermittent Python 3.5 failures due to dictionary ordering differences.

https://travis-ci.org/simonw/datasette/jobs/378356802

```

  assert expected_facet_results == facet_results

E AssertionError: assert {'city': [{'c...alue': 'MI'}]} == {'city': [{'co...alue': 'MI'}]} E Omitting 1 identical items, use -vv to show E Differing items: E {'city': [{'count': 4, 'toggle_url': '_facet=state&_facet=city&state=MI&city=Detroit', 'value': 'Detroit'}]} != {'city': [{'count': 4, 'toggle_url': 'state=MI&_facet=state&_facet=city&city=Detroit', 'value': 'Detroit'}]} E Use -v to get the full diff ```

To solve these cleanly I need to be able to run Python 3.5 on my local laptop rather than relying on Travis every time.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Refactor views 322591993  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 18.463ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows