issue_comments

Table actions

3 rows where issue = 499954048 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Added support for multi arch builds · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
553555517 https://github.com/simonw/datasette/pull/578#issuecomment-553555517 https://api.github.com/repos/simonw/datasette/issues/578 MDEyOklzc3VlQ29tbWVudDU1MzU1NTUxNw== simonw 9599 2019-11-13T19:13:15Z 2019-11-13T19:13:15Z OWNER

Yes I'm going to hold of on this until the Docker feature is less experimental.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Added support for multi arch builds 499954048  
541837823 https://github.com/simonw/datasette/pull/578#issuecomment-541837823 https://api.github.com/repos/simonw/datasette/issues/578 MDEyOklzc3VlQ29tbWVudDU0MTgzNzgyMw== heussd 887095 2019-10-14T18:19:42Z 2019-10-14T18:19:42Z NONE

My use case was: I wanted to use datasette on a Raspberry Pi. docker pull datasetteproject/datasette pulled the official image, which then failed to execute because it is not ARM ready. Building my own quite took some time (~60 minutes via Qemu on Intel i5).

You are right, the build method is quite new and I would not be surprised if the syntax / command will change in future. The outcome however, a Docker multi-architecture manifest, is aligned with Docker's strategy on how to tackle multiple architectures: transparently, on the registry-side.

I just thought it would be nice to have the official image ready for multiple architectures. But I fully understand if the current methods feel too experimental to be mergable...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Added support for multi arch builds 499954048  
541495682 https://github.com/simonw/datasette/pull/578#issuecomment-541495682 https://api.github.com/repos/simonw/datasette/issues/578 MDEyOklzc3VlQ29tbWVudDU0MTQ5NTY4Mg== simonw 9599 2019-10-14T03:57:17Z 2019-10-14T03:57:17Z OWNER

So this is a new Docker feature from April 2019? https://engineering.docker.com/2019/04/multi-arch-images/

So why buildx? Let’s first start with the name. The x stands for experimental. In the future, when these new build features are stable and made generally available, we will drop the x and integrate these features directly into the existing docker build command. Note that as buildx is experimental, features and flags are subject to change.

Is there a strong use-case for supporting this while it's still experimental? Users who want Datasette to run on ARM can build their own image pretty easily, so I'm not sure if it's worth depending on an experimental feature for the core Datasette project.

Is there any indication from the Docker team as to when this experimental feature might stop being marked as experimental?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Added support for multi arch builds 499954048  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);