issue_comments

Table actions

4 rows where issue = 763361458 and user = 6622733 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • nitinpaultifr · 4 ✖

issue 1

  • "Stream all rows" is not at all obvious · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
745162571 https://github.com/simonw/datasette/issues/1142#issuecomment-745162571 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0NTE2MjU3MQ== nitinpaultifr 6622733 2020-12-15T09:22:58Z 2020-12-15T09:22:58Z NONE

You're right, probably more straightforward to have the links for JSON. I was imagining to toggle the href for the 'Export JSON' link (button) to the selected shape, but it'll probably be needlessly complex in the end.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
744522099 https://github.com/simonw/datasette/issues/1142#issuecomment-744522099 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0NDUyMjA5OQ== nitinpaultifr 6622733 2020-12-14T15:37:47Z 2020-12-14T15:37:47Z NONE

Alright I could give it a try! This might be a stupid question, can you tell me how to run the server from my fork? So that I can test the changes?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
743998792 https://github.com/simonw/datasette/issues/1142#issuecomment-743998792 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0Mzk5ODc5Mg== nitinpaultifr 6622733 2020-12-13T12:14:06Z 2020-12-13T12:14:06Z NONE

Agreed, it would definitely provide better controls. However, I do feel it makes for a bit of inconsistent UX for the 'Advanced export' section, with links to download for JSON, checkboxes and radio buttons + button to download for CSV. Do you think this example makes the UX a bit nicer/consistent?

I could give it a try if you'd like but I've never contributed to an actual project!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
743732440 https://github.com/simonw/datasette/issues/1142#issuecomment-743732440 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0MzczMjQ0MA== nitinpaultifr 6622733 2020-12-12T09:56:40Z 2020-12-12T09:56:40Z NONE

'Include all rows' seem like a fairly obvious alternative

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);