issue_comments

Table actions

8 rows where issue = 969855774 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 3

issue 1

  • Rename Datasette.__init__(config=) parameter to settings= · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
946287922 https://github.com/simonw/datasette/issues/1432#issuecomment-946287922 https://api.github.com/repos/simonw/datasette/issues/1432 IC_kwDOBm6k_c44ZzUy mroswell 192568 2021-10-19T01:16:41Z 2021-10-19T01:16:41Z CONTRIBUTOR

Resolved, with assistance from @ashishdotme (Thank you!)

Updated requirements.txt to include: datasette==0.59 datasette-publish-vercel==0.11 sqlite-utils==3.6

Ran: $ pip3 install -r requirements.txt The site is back at work! Yay!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename Datasette.__init__(config=) parameter to settings= 969855774  
946255239 https://github.com/simonw/datasette/issues/1432#issuecomment-946255239 https://api.github.com/repos/simonw/datasette/issues/1432 IC_kwDOBm6k_c44ZrWH mroswell 192568 2021-10-18T23:55:25Z 2021-10-18T23:55:25Z CONTRIBUTOR

I am getting this when I visit my live Datasette page: This Serverless Function has crashed. Your connection is working correctly. Vercel is working correctly. 500: INTERNAL_SERVER_ERROR Code: FUNCTION_INVOCATION_FAILED ID: ... And in the server logs, I'm getting

[GET] /disinfectants/listN 19:53:14:23 module initialization error: __init__() got an unexpected keyword argument 'config' module initialization error __init__() got an unexpected keyword argument 'config' Which is the same error that @ashishdotme reported above.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename Datasette.__init__(config=) parameter to settings= 969855774  
945639639 https://github.com/simonw/datasette/issues/1432#issuecomment-945639639 https://api.github.com/repos/simonw/datasette/issues/1432 IC_kwDOBm6k_c44XVDX ashishdotme 5802411 2021-10-18T10:44:56Z 2021-10-18T10:44:56Z NONE

@simonw I am getting the below issue again now, even after removing branch argument from vercel datasette plugin

module initialization error: init() got an unexpected keyword argument 'config' module initialization error init() got an unexpected keyword argument 'config'

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename Datasette.__init__(config=) parameter to settings= 969855774  
941585767 https://github.com/simonw/datasette/issues/1432#issuecomment-941585767 https://api.github.com/repos/simonw/datasette/issues/1432 IC_kwDOBm6k_c44H3Vn ashishdotme 5802411 2021-10-12T21:23:19Z 2021-10-12T21:23:19Z NONE

Nevermind, had to remove the branch argument in the workflow to make vercel publish work

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename Datasette.__init__(config=) parameter to settings= 969855774  
941002127 https://github.com/simonw/datasette/issues/1432#issuecomment-941002127 https://api.github.com/repos/simonw/datasette/issues/1432 IC_kwDOBm6k_c44Fo2P ashishdotme 5802411 2021-10-12T13:14:31Z 2021-10-12T13:14:39Z NONE

Any workaround for making it work with datasette-publish-vercel. Currently getting below error

module initialization error: init() got an unexpected keyword argument 'config' module initialization error init() got an unexpected keyword argument 'config'

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename Datasette.__init__(config=) parameter to settings= 969855774  
898084675 https://github.com/simonw/datasette/issues/1432#issuecomment-898084675 https://api.github.com/repos/simonw/datasette/issues/1432 IC_kwDOBm6k_c41h69D simonw 9599 2021-08-13T01:11:30Z 2021-08-13T01:11:30Z OWNER

It's only datasette-publish-vercel that will break the actual functionality - the others will have broken tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename Datasette.__init__(config=) parameter to settings= 969855774  
898079507 https://github.com/simonw/datasette/issues/1432#issuecomment-898079507 https://api.github.com/repos/simonw/datasette/issues/1432 IC_kwDOBm6k_c41h5sT simonw 9599 2021-08-13T01:08:42Z 2021-08-13T01:09:41Z OWNER

This is going to break some plugins: https://ripgrep.datasette.io/-/ripgrep?pattern=config%3D&literal=on&glob=%21datasette%2F**

datasette-cluster-map/tests/test_cluster_map.py

@pytest.mark.asyncio

async def test_respects_base_url(): ds = Datasette([], memory=True, config={"base_url": "/foo/"}) response = await ds.client.get("/:memory:?sql=select+1+as+latitude,+2+as+longitude") assert (

datasette-export-notebook/tests/test_export_notebook.py

@pytest.mark.asyncio

async def test_notebook_no_csv(db_path): datasette = Datasette([db_path], config={"allow_csv_stream": False}) response = await datasette.client.get("/db/big.Notebook") assert ".csv" not in response.text

datasette-publish-vercel/tests/test_publish_vercel.py

metadata=metadata, cors=True, config={"default_page_size": 10, "sql_time_limit_ms": 2000} ).app() """

datasette-publish-vercel/datasette_publish_vercel/init.py

metadata=metadata{extras}, cors=True, config={settings}

).app()

""".strip()

datasette-search-all/tests/test_search_all.py

async def test_base_url(db_path, path): sqlite_utils.Database(db_path)["creatures"].enable_fts(["name", "description"]) datasette = Datasette([db_path], config={"base_url": "/foo/"}) response = await datasette.client.get(path) assert response.status_code == 200

I should fix those as soon as this goes out in a release. I won't close this issue until then.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename Datasette.__init__(config=) parameter to settings= 969855774  
898074849 https://github.com/simonw/datasette/issues/1432#issuecomment-898074849 https://api.github.com/repos/simonw/datasette/issues/1432 IC_kwDOBm6k_c41h4jh simonw 9599 2021-08-13T01:03:40Z 2021-08-13T01:03:40Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename Datasette.__init__(config=) parameter to settings= 969855774  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);