issue_comments

Table actions

12 rows where "updated_at" is on date 2018-05-22 and user = 9599 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 12 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
391076458 https://github.com/simonw/datasette/pull/280#issuecomment-391076458 https://api.github.com/repos/simonw/datasette/issues/280 MDEyOklzc3VlQ29tbWVudDM5MTA3NjQ1OA== simonw 9599 2018-05-22T17:34:13Z 2018-05-22T17:34:13Z OWNER

Yeah let's try this without pysqlite3 and see if we still get the correct version.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Build Dockerfile with recent Sqlite + Spatialite 325373747  
391076239 https://github.com/simonw/datasette/pull/280#issuecomment-391076239 https://api.github.com/repos/simonw/datasette/issues/280 MDEyOklzc3VlQ29tbWVudDM5MTA3NjIzOQ== simonw 9599 2018-05-22T17:33:33Z 2018-05-22T17:33:33Z OWNER

This looks amazing! Can't wait to try this out this evening.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Build Dockerfile with recent Sqlite + Spatialite 325373747  
391055490 https://github.com/simonw/datasette/pull/279#issuecomment-391055490 https://api.github.com/repos/simonw/datasette/issues/279 MDEyOklzc3VlQ29tbWVudDM5MTA1NTQ5MA== simonw 9599 2018-05-22T16:29:30Z 2018-05-22T16:29:30Z OWNER

This is fantastic!

I think I prefer the aesthetics of just "0.22" for the version string if it's a tagged release with no additional changes - does that work?

I'd like to continue to provide a tuple that can be imported from the version.py module as well, as seen here:

https://github.com/simonw/datasette/blob/558d9d7bfef3dd633eb16389281b67d42c9bdeef/datasette/version.py#L1

Presumably we can generate that from the versioneer string?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add version number support with Versioneer 325352370  
391030083 https://github.com/simonw/datasette/issues/243#issuecomment-391030083 https://api.github.com/repos/simonw/datasette/issues/243 MDEyOklzc3VlQ29tbWVudDM5MTAzMDA4Mw== simonw 9599 2018-05-22T15:17:10Z 2018-05-22T15:17:10Z OWNER

See also #278

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 --spatialite option for datasette publish commands 318737808  
391025841 https://github.com/simonw/datasette/issues/276#issuecomment-391025841 https://api.github.com/repos/simonw/datasette/issues/276 MDEyOklzc3VlQ29tbWVudDM5MTAyNTg0MQ== simonw 9599 2018-05-22T15:06:36Z 2018-05-22T15:06:36Z OWNER

The other reason I mention plugins is that I have an idea to outlaw JavaScript entirely from Datasette core and instead encourage ALL JavaScript functionality to move into plugins.right now that just means CodeMirror. I may set up some of those plugins (like CodeMirror) as default dependencies so you get them from "pip install datasette".

I like the neatness of saying that core Datasette is a very simple JSON + HTML application, then encouraging people to go completely wild with JavaScript in the plugins.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Handle spatialite geometry columns better 324835838  
390993861 https://github.com/simonw/datasette/issues/278#issuecomment-390993861 https://api.github.com/repos/simonw/datasette/issues/278 MDEyOklzc3VlQ29tbWVudDM5MDk5Mzg2MQ== simonw 9599 2018-05-22T13:40:14Z 2018-05-22T14:38:05Z OWNER

If we can't get import sqlite3 to load the latest version but we can get import pysqlite3 to work that's fine too - I can teach Datasette to import the best available version.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Build smallest possible Docker image with Datasette plus recent SQLite (with json1) plus Spatialite 4.4.0 325294102  
391011268 https://github.com/simonw/datasette/issues/272#issuecomment-391011268 https://api.github.com/repos/simonw/datasette/issues/272 MDEyOklzc3VlQ29tbWVudDM5MTAxMTI2OA== simonw 9599 2018-05-22T14:28:12Z 2018-05-22T14:28:12Z OWNER

I think I can do this almost entirely within my existing BaseView class structure.

First, decouple the async data() methods by teaching them to take a querystring object as an argument instead of a Sanic request object. The get() method can then send that new object instead of a request.

Next teach the base class how to obey the ASGI protocol.

I should be able to get support for both Sanic and uvicorn/daphne working in the same codebase, which will make it easy to compare their performance. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Port Datasette to ASGI 324188953  
391003285 https://github.com/simonw/datasette/issues/273#issuecomment-391003285 https://api.github.com/repos/simonw/datasette/issues/273 MDEyOklzc3VlQ29tbWVudDM5MTAwMzI4NQ== simonw 9599 2018-05-22T14:06:40Z 2018-05-22T14:06:40Z OWNER

That looks great. I don't think it's possible to derive the current commit version from the .zip downloaded directly from GitHub, so needing to pip install via git+https feels reasonable to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Figure out a way to have /-/version return current git commit hash 324451322  
391000659 https://github.com/simonw/datasette/issues/276#issuecomment-391000659 https://api.github.com/repos/simonw/datasette/issues/276 MDEyOklzc3VlQ29tbWVudDM5MTAwMDY1OQ== simonw 9599 2018-05-22T13:59:27Z 2018-05-22T13:59:27Z OWNER

Right now the plugin stuff is early enough that I'd like to get as many potential plugin hooks as possible crafted out A much easier to judge if they should be added as actual hooks if we have a working branch prototype of them.

Some kind of mechanism for custom column display is already needed - eg there are columns where I want to say "render this as markdown" or "URLify any links in this text" - or even "use this date format" or "add commas to this integer".

You can do it with a custom template but a lower-level mechanism would be nicer. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Handle spatialite geometry columns better 324835838  
390999055 https://github.com/simonw/datasette/issues/255#issuecomment-390999055 https://api.github.com/repos/simonw/datasette/issues/255 MDEyOklzc3VlQ29tbWVudDM5MDk5OTA1NQ== simonw 9599 2018-05-22T13:54:55Z 2018-05-22T13:54:55Z OWNER

This shipped in Datasette 0.22. Here's my blog post about it: https://simonwillison.net/2018/May/20/datasette-facets/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Facets 322477187  
390993397 https://github.com/simonw/datasette/issues/278#issuecomment-390993397 https://api.github.com/repos/simonw/datasette/issues/278 MDEyOklzc3VlQ29tbWVudDM5MDk5MzM5Nw== simonw 9599 2018-05-22T13:38:57Z 2018-05-22T13:38:57Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Build smallest possible Docker image with Datasette plus recent SQLite (with json1) plus Spatialite 4.4.0 325294102  
390991640 https://github.com/simonw/datasette/issues/278#issuecomment-390991640 https://api.github.com/repos/simonw/datasette/issues/278 MDEyOklzc3VlQ29tbWVudDM5MDk5MTY0MA== simonw 9599 2018-05-22T13:33:46Z 2018-05-22T13:33:46Z OWNER

For SpatiaLite this example may be useful - though it's building 4.3.0 and not 4.4.0: https://github.com/terranodo/spatialite-docker/blob/master/Dockerfile

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Build smallest possible Docker image with Datasette plus recent SQLite (with json1) plus Spatialite 4.4.0 325294102  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);